Place same-rail load partitions after decoupling capacitor rows - #192
Draft
mohan-bee wants to merge 1 commit into
Draft
Place same-rail load partitions after decoupling capacitor rows#192mohan-bee wants to merge 1 commit into
mohan-bee wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Generic partition packing can place a rail-connected load chain on the opposite side of its matching decoupling capacitors. In the captured power-section repro, the
R1–LED1partition bridges the same positive and ground rails asC3/C4, but it was placed to the left instead of following the capacitor row on the right. This makes the power section harder to read even though the internal load-chain placement is valid.Change
PlaceRailConnectedLoadsSolverpipeline phase after decoupling-row placement.partitionGap.Evidence
The existing
repro-power-section.input.jsonfixture now produces this order on the shared rails:U3 → C3 → C4 → R1/LED1The regression asserts that:
partitionGapafter the capacitor row;R1andLED1stay vertically aligned;The SVG snapshot records the corrected schematic placement.
Tests
bunx biome format .bunx tsc --noEmitbun test— 81 passed, 1 skipped, 0 failedbun run build