fix(sot343): symmetrize pads to match KiCad SOT-343 (#667) - #711
fix(sot343): symmetrize pads to match KiCad SOT-343 (#667)#711yanyishuai wants to merge 1 commit into
Conversation
2f4d3bc to
358010a
Compare
|
CI is green on 358010a (build/test/format-check/Format code all success). |
|
CI green — ready for review/merge on 358010a. Happy to address any feedback. |
|
Still CI-green and mergeable — gentle merge ping on 358010a. Happy to address any remaining feedback. |
358010a to
09f811c
Compare
09f811c to
2965ee2
Compare
|
Rebased onto latest main (kept cornerRadius). Pads ±p*1.5, mirrored courtyard, radix 10, KiCad IoU 100%. CI green on 2965ee2. |
|
Merge ping — CI green / mergeable=clean on 2965ee2 (sot343 symmetry). Please merge when convenient — payout blocked on merge. |
|
Merge-ready follow-up — CI green on #711 (Fixes #667 SOT-343 pad symmetry). KiCad-aligned Happy to address any remaining review notes immediately. Wallet (if bounty payout applies): |
Summary
Fixes the lopsided
sot343land pattern reported in #667.Root cause
x: -p * 1.5(after aligning to KiCad), but right pads used barex: p, shifting the part off-center.Number.parseInt(..., 4)forsot343_Nused the wrong radix ("4"?NaN).Fix
?p * 1.5for both pad columns (matches KiCadSOT-343_SC-70-4; courtyard IoU 100% / diff 0%).10.Evidence
Note vs earlier approaches
Keeping left at
p*1.92and only fixing the right side improves symmetry but fails KiCad parity (~15% courtyard diff). This PR prioritizes the repo's KiCad reference.Fixes #667