Skip to content

Add visual repros for PCB placement layer bugs - #181

Closed
seveibar wants to merge 3 commits into
mainfrom
repro/pcb-placement-layers
Closed

Add visual repros for PCB placement layer bugs#181
seveibar wants to merge 3 commits into
mainfrom
repro/pcb-placement-layers

Conversation

@seveibar

@seveibar seveibar commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a failing visual repro for a multi-hole footprint whose later drilled hole intersects an opposite-side courtyard
  • add a failing visual repro for overlapping same-layer polygon courtyards
  • label each snapshot with pcb_note_text so the missing expected error is explicit

Confirmed bugs

  1. checkPcbComponentOverlap only retains the first pcb_hole for a component, so a later mechanical hole can intersect an opposite-side courtyard without an error.
  2. checkCourtyardOverlap omits pcb_courtyard_polygon elements, so same-layer polygon courtyard collisions are not reported.

Both repros use test.failing so the current bugs are documented without breaking CI. A follow-up PR can implement the fixes, remove test.failing, and update the snapshots with the expected error markers.

Validation

  • bun test — 143 pass
  • bunx tsc --noEmit
  • bun run build
  • bun run format:check

@seveibar seveibar closed this Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant