fix(recall): recover community participation sets from joined activities - #175
Merged
Merged
Conversation
Enumerate joined/attended/organizing/mentorship objects for "in what ways … community" questions so leftover courage slogans cannot crowd out the typed participation list. Co-authored-by: aria <aria@engramhq.com>
Compiler 'attended back' / 'attended not-so-great' rows were filling the activity-hop cap before organizing/host art-show objects. Primary cues now win the first slots; article-only participating-in still extracts 'show' lists without hobby 'participates in hiking'. Co-authored-by: aria <aria@engramhq.com>
Same skip-ingest 180 as P61. Unique +1/-0: conv-26-q39 leftover courage slogan to joined/organizing/mentorship/pride set. Co-authored-by: aria <aria@engramhq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip-ingest 180 leftover
conv-26-q39(“In what ways is Caroline participating in the LGBTQ community?”) currently answers with a transition-courage leftover even though the frozen store already has joined/attended/organizing/mentorship facts (activist group, pride parade, art show, mentorship program). This is an S2 enumerate miss, not a WRITE gap.This change recovers those objects from listed memories for in what ways / ways + community questions, locks enumerate to the activity hop, and keeps the typed join against leftover covering. Cues are generic (
joined/organizing/host/ articleparticipating in/mentorship program, thenattended) — not an LGBTQ/activist/parade gold dictionary. Bareparticipates in hiking,attended back, andcontacted her mentor for adoption advicedo not extract. Joined/organizing/host slots are ranked ahead of attended compiler junk so the activity-hop cap cannot drop the art-show object.P61 pin remains 144/180. This PR is a candidate for ≥145/180 only after a live probe and the same skip-ingest 180. Do not treat 144/180 as 90% or as beating Mem0.
Changes
internal/memory/hop_executor.go:looksParticipationSetQuery, two-passrecoverParticipationSlots(primary joined/organizing/host/participating-in-article, then attended), thin-stop forback/not-so-great, tails forscheduled/featuring/in.internal/memory/recall.go: historical scan + enumerate lock to activity; skip dual-entity join; keep typed participation joins vs leftover covering (≤400 runes); named-community token filter still runs.internal/memory/recall_test.go: Caroline-like set vs nurse/hiking/courage/adoption/attended-junk leftovers; detector/object unit tests; leftover-covering keep case.Test plan
gofmton touched filesunset BRAINY_DATABASE_URL; go test ./internal/memory/(ok after ranking fix):18100after rebuild:conv-26-q39is activist/pride/art/mentor, not courage; P61 holds (q22 shelter/homeless/hospital, food q18, soda/candy, Audrey collars, James tricks, Maria dogs, Jolene snakes)--fail-closed --tenant-prefix diag-mh-135 --stratified 180 --seed 1 --conversations 10) pin only if ≥145/180 vs P61 144/180 and no unique leftover lossesgo vet ./...before mergeLinear / tracking
ENG-176 (MH lists / S2), parent ENG-168.
Risk / follow-ups
conv-49-q78) is the next S2 candidate after this pin.main. Do not merge leftover-covering PRs S1–S5 compiler/answer/alias/KU (split from mixed S0 PR) #133, S0–S5 SOTA execution increments (stratified harness + compiler/answer/hop/LME) #131, fix(recall): instrument-purpose leftover covering over help flood #143, P29: demote single-token attended compiler echoes (ranking only) #145.