Skip to content

S2: recover food-set and charity-beneficiary lists (P61 144/180) - #174

Merged
cursor[bot] merged 0 commit into
devfrom
pr/s2-food-given-sets-1e9e
Aug 26, 2026
Merged

cursor[bot] merged 0 commit into
devfrom
pr/s2-food-given-sets-1e9e

Conversation

@sdntsng

@sdntsng sdntsng commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Product /recall recovers beneficiary organization sets for who/which beneficiary questions. Frozen skip-ingest store already had John's raise-for objects (dog shelter, homeless, children's hospital); leftover covering was answering with the CS:GO tournament slogan.

Skip-ingest 180 on this SHA: 144/180 vs P59 143/180. Unique CORRECT +1 (conv-47-q22). Unique leftover losses none. MH 24/33, OD 4/11, SH 85/98, temporal 31/38.

This is generic S2 enumerate, not leftover covering and not a LoCoMo gold dictionary. Food-set work on this branch did not flip the 180 (judge completeness + WRITE-missing gold); p60/p60b 143/180 are not pins.

90% on this 180 is 162/180. Public LoCoMo n=1540 is still 11.4%. Do not treat 144/180 as 90% or as beating Mem0. README published-% / 1×30 70% are not replaced.

Changes

  • looksBeneficiarySetQuery — who/which/what + beneficiaries/beneficiary.
  • recoverBeneficiarySlots / beneficiaryObjectsFromContent — raise/for-cues; thin-stop charity/CS:GO/tournament; cap 6.
  • Recovered slots replace the named person's affiliation hop.
  • Enumerate: no dual-entity join; lock to affiliation hops.
  • leftoverCoveringKeepTypedAnswer keeps a ≥2 affiliation join.
  • Pin docs: P61 144/180 closeout + benchmarks README row.

Test plan

  • gofmt on touched files
  • go vet ./internal/memory/ ./cmd/api ./cmd/worker
  • go test ./internal/memory/ (23.5s, green)
  • Live probe conv-47-q22: dog shelter, homeless, children's hospital (not CS:GO); P59/P60 holds (food q18, soda/candy, Audrey collars, James tricks, Maria dogs, Jolene snakes, dinner leftover)
  • Skip-ingest 180 locomo-s0-diag-mh-135-p61-product-recall-s1-02435b 144/180, unique +1/−0 vs P59
  • Pin docs; FF origin/dev (not main)

Linear / tracking

  • ENG-176 (MH) / parent ENG-168

Risk / follow-ups

Open in Web Open in Cursor 

@cursor cursor Bot changed the title S2: meal and suggestion food sets S2: recover given-to meal and suggestion food sets Aug 26, 2026
@cursor cursor Bot changed the title S2: recover given-to meal and suggestion food sets S2: recover food-set and charity-beneficiary lists Aug 26, 2026
@cursor cursor Bot changed the title S2: recover food-set and charity-beneficiary lists S2: recover food-set and charity-beneficiary lists (P61 144/180) Aug 26, 2026
@cursor
cursor Bot merged commit 521f4ba into dev Aug 26, 2026
@sdntsng
sdntsng deployed to dev - brainy-worker-staging August 26, 2026 13:19 — with Render Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant