S2: dest-class lists (P59 143/180) - #173
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
S2 enumerate for dest-being skill sets, transfer-cue item objects, and possessed-class dest names. Same-store skip-ingest 180 on tenant
diag-mh-135is 143/180 (0.794) vs P58 141/180. Unique gains: Audrey dog items (conv-44-q51) and James pet tricks (conv-47-q40). Unique leftover losses: none.This is not leftover covering. It is not 90% (162/180 on this sample; public LoCoMo is n=1540 at 11.4%). It is not a Mem0 same-pin. Do not replace README 11.4% / 70% 1×30.
Not-pins on this branch: p59 142/180 (Jolene snakes leftover loss) and p59b 142/180 (Maria dogs crowded with generic
namedDavid).Product SHA:
2111b3b. Pin-docs SHA:7582832(FF target fordev).Changes
internal/memory/hop_executor.go/internal/memory/recall.go: dest-being skills recover dest capabilities (swim/catch/balance/skateboard) without requiringtrick; dest-adjacent identity dumps stay out. Transfer-cue item objects (buy/acquired/purchased;got/madeonly withfor/gift) recover collars/tags/toys/beds; coded keys and slogan-filtered transfer objects stay in when they have a transfer cue. Name lists recover dests from a possessed-class token plusnamed/called, not genericnamed Xfriends.internal/memory/recall_test.go: fixtures for transferred item sets, dest-only tricks, possessed-class names (Coco+Shadow not David; Jolene snakes not identity dumps).docs/benchmarks/README.mdP59 row;docs/research/competitive/cycle-closeout.mdP59 section (Landed → Own pins → Competitor compare → Why → Next); artifactlocomo-s0-diag-mh-135-p59-20260826.md+ summary JSON + failure ledger jsonl.Test plan
go test ./internal/memory/(unit fixtures for transfer / dest skills / possessed-class names)locomo-s0-diag-mh-135-p59c-product-recall-s1-5336d8→ 143/180, MH 23/33, OD 4/11, SH 85/98, temporal 31/38; unique losses none vs P58gofmt -l ./go vet ./...on mergeLinear / tracking
Risk / follow-ups
conv-49-q18,conv-49-q37) without soda/candy hop dumps; then S2b OD; then S1 WRITE with re-ingest; then S5 industry (62/180).main. Do not write SOTA / beats-Mem0.