fix(recall): cover what-new-series leftover on quoted titled show - #165
Merged
Merged
Conversation
Admit leftover that quotes a watch/show/titled work so generic excitement leftover and quoted novels cannot steal the answer. Co-authored-by: aria <aria@engramhq.com>
Co-authored-by: aria <aria@engramhq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Isolated P49 leftover covering for
what+new+series/showqueries. Hybrid previously answered Tim's "new fantasy TV series" question (conv-43-q162) from generic leftoverI'm really excited about this new journeyeven though gold leftover is stored:Tim: I'm really excited to watch this new show that's coming out called "The Wheel of Time"(recency rank 314, inside the 400-row subject corpus).The product change admits leftover that quotes a titled show (
watch/show/coming out/titled+tv/series) with a first-person or named actor. Quoted novels (The Name of the Wind) and unquoted other-series leftover (Game of Thrones) do not cover. Fail-closed if the titled-show leftover is missing. No Wheel of Time / fantasy dictionary. No LoCoMo-named product rules.Skip-ingest 180 is net-positive vs P48 132/180: 133/180 (0.739). Unique gain
conv-43-q162. Unique losses none. SH 80→81. MH/OD/temporal held. Pin docs are in this PR. Goal remains 162/180. Does not replace README 11.4% / 70% 1×30.Changes
looksWhatNewSeriesQuery—what+new+series/show. Does not match focusing-besides, how-plan-dream, dated what-new-hobby.leftoverCoveringTitledShowLine— quoted title + watch/show/coming-out/titled-tv cue; rejects novel/book leftover that lacks those cues; actor is first-person (including after a speaker prefix) or a named query person.new/fantasy/tv/series/excited/aboutonly on this query shape. Subject corpus lists 400 rows so titled-show leftover at recency 314 can seed session expand. Floor 0.9; rank boost 0.75; keep-in-cap; episode keep.Test plan
go vet ./...go test ./...(EXIT:0)/recallgain:conv-43-q162contains Wheel of Time, not new journey / Name of the Wind / Game of Thrones (21/21 holds including P48 relationship leftover)locomo-s0-diag-mh-135-p49= 133/180 vs 132/180 (+1 / −0)Linear / tracking
Risk / follow-ups
conv-41-q145, gold not stored).conv-50-q142Japanese-house party leftover (stored; pred drops album). Alternateconv-48-q177mindfulness-joy leftover.