fix(recall): cover focusing-besides leftover on possessive conjunct - #164
Merged
Merged
Conversation
Admit first-person focusing-on leftover that covers the besides-object and joins a possessive conjunct, so occupation leftover cannot steal the answer. Co-authored-by: aria <aria@engramhq.com>
Co-authored-by: aria <aria@engramhq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Isolated P48 leftover covering for
what has/have/is/was+ focus/focusing + besides/except/aside queries. Hybrid previously answered Jolene's "besides studying" question (conv-48-q169) from occupation leftover ("engineering skills" / "social causes") even though gold leftover is stored:I've been focusing on studying and my relationship with my partner.The product change admits first-person
focusing onleftover that covers the besides-object and joins a possessive conjunct (and my/and our). Occupation leftover that also saysfocusing ondoes not cover. Fail-closed if the join leftover is missing. No relationship dictionary. No engineering keyword. No LoCoMo-named product rules.Skip-ingest 180 is net-positive vs P47 131/180: 132/180 (0.733). Unique gain
conv-48-q169. Unique losses none. SH 79→80. MH/OD/temporal held. Pin docs are in this PR. Goal remains 162/180. Does not replace README 11.4% / 70% 1×30.Changes
looksWhatFocusingBesidesQuery—what has/have/is/was+ focus/focusing + besides/except/aside + besides-object tokens. Does not match how-plan-dream, how-often, what-project-working, dated what-new-hobby, or focusing without besides.leftoverCoveringFocusingBesidesLine—focusing on+ actor (I/I've/I'm/my) + besides-object overlap + possessive conjunctand my/and our.focusing onleftover without the possessive join (no occupation keyword list).besides/except/aside/latelyonly on this query shape; keepsfocusing/studying. Session rank prefers covering leftover sessions. Floor 0.9; rank boost 0.75; keep-in-cap; episode keep.Test plan
gofmt -lon touched filesgo vet ./...go test ./...(EXIT:0)/recallgain:conv-48-q169contains relationship/partner, not engineering/social-causes (20/20 holds including P47 surf)locomo-s0-diag-mh-135-p48= 132/180 vs 131/180 (+1 / −0)Linear / tracking
Risk / follow-ups
conv-41-q145, gold not stored).besides/focusing/studyingglobally.conv-43-q162Wheel of Time leftover (stored; pred is generic new-journey). Alternateconv-50-q142Japanese-house party leftover drops album. Do not special-case German vs Spanish.