fix(recall): P47 how-plan-dream leftover covering - #163
Merged
Merged
Conversation
How-plan-dream leftover covering was matching foreign-person "learning their stories" restatements because the gold gathering/watching/guide line is comma-split and skipped as a hop dump. Prefer first-person prep leftover, drop plan/pursue/dream/learning from FTS, and fail closed unless that leftover is in store. Co-authored-by: aria <aria@engramhq.com>
Same-store skip-ingest 180 recovered Jolene surf-plan leftover (gathering/watching/guide over Deborah exploring). Unique +1 / -0. Co-authored-by: aria <aria@engramhq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same-store LoCoMo 180 P47 isolated increment vs P46 130/180 is net-positive: 131/180 (0.728). Unique Next
conv-48-q124(“How does Jolene plan to pursue her dream of learning to surf?”) recovered. Gold leftoverI've been gathering information, watching videos, and I even got a beginners' guide to surfingis stored insession_10; P46 leftover covering emitted Deborah’sExploring historical places and learning their stories is so funbecause FTS ANDedlearningand the gold line is comma-split (hop-dump skip).This PR adds generic how-plan-dream leftover covering: prefer first-person gathering/watching/guide leftover with learn-object overlap, fail closed unless that leftover is present, drop
plan/pursue/dream/learningfrom FTS, skip hybrid when covering fires. No surf / Deborah / historical-places dictionary. Do not dropsurfglobally.Item flips vs P46: +1 / −0. Unique gain
conv-48-q124. Unique losses none. MH 18 / OD 4 / SH 79 / temporal 30. Ledger RETRIEVAL 18→17, PROOF 20, READER 7, WRITE 4, HARNESS 1.Changes
looksHowPlanDreamQuery—how does/did/do/will+ plan/pursue + dream + learn/learning. Does not match how-often, how-long-been, how-did-start, what-project-working, dated what-new-hobby, or plan-without-dream.leftoverCoveringPrepPlanLine— cue (gathering information/watching videos/beginners' guide) + actor + learn-object overlap (surf↔surfing). Prefer highest cue count so the combined leftover beats a single compiler fact.surf. Session rank / floor 0.9 / rank boost 0.75 /keepPrepPlanInCap.Test plan
learningand keepssurf; session expand / cap keepgofmt -l .clean on touched Go filesgo vet ./...go test ./.../recallconv-48-q124is gathering/videos/guide leftover (reader_sourceleftover_packet_fact), not Deborah exploringlocomo-s0-diag-mh-135-p47-product-recall-s1-36b2f6131/180 net-positive vs 130/180Linear / tracking
Risk / follow-ups
conv-41-q145, gold not stored) — do not chase.conv-48-q169).conv-48-q116harness timeout).surfglobally.