fix(recall): cover what-project leftover on currently-working (P45, 129/180) - #161
Merged
Merged
Conversation
Prefer currently-working leftover over childhood desire or creating-own restatements for what-project queries, without a football or comic-sketch dictionary. Co-authored-by: aria <aria@engramhq.com>
Co-authored-by: aria <aria@engramhq.com>
sdntsng
marked this pull request as ready for review
August 25, 2026 18:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P44 pinned 128/180. Remaining SH RETRIEVAL unique
conv-47-q94(“What project is James working on in his game design course?”) failed because FTS ANDedproject/game/design/courseagainst a currently-working leftover that has none of those tokens, then hybrid stole childhood comic-sketch desire / “creating his own game project.”This ships isolated leftover covering for what-project + working queries: prefer currently-working / working-on-a-new leftover, drop trailing
in … courseadjuncts, skip hybrid so comic-sketch hops cannot win, and fail closed unless currently-working leftover is in the packet.Skip-ingest 180
locomo-s0-diag-mh-135-p45-product-recall-s1-323b12is 129/180 (0.717) — net +1 / −0 vs P44. Unique gain:conv-47-q94. Unique losses: none. MH 18/33, OD 4/11, SH 77/98, temporal 30/38. Ledger RETRIEVAL 20→19. SH RETRIEVAL 4→3.No football / comic-sketch / game-design dictionary. Childhood desire and “creating his own … project” without
currentlystay companions. Peer FIFA and sibling coding leftovers do not cover.Changes
looksWhatProjectWorkingQuery—what+project+working/work; excludes how-often, how-long-been, how-did-start, what-did-purpose, how-describe, how-react.leftoverCoveringCurrentProjectLine—currently working/working on a newplus actor (I/ named entity); rejects childhood / as-a-child / since-kid.in … course/classadjunct and structure tokens (project/course/class); session-rank currently-working leftover sessions 100; floor 0.9; rank boost 0.75;keepCurrentProjectInCap.Test plan
gofmton touched filesgo vet ./internal/memory/go test ./internal/memory/ -run 'WhatProjectWorking|HowOften|HowLongBeen|KeepCurrentProject|KeepCadence|SearchLexicalQueryTokensDrops'go test ./...(full suite, warm cache)/recall17/17: gainconv-47-q94currently-working football leftover; holds P44 once-a-week, P43 married 5 years, P42 diet+walking, P41 dog-owners, dogs/snow, injury, NYC, dancers, writing, turtle, electronic, dinner, advice, veterans, push, smartwatchlocomo-s0-diag-mh-135-p45129/180 net-positive vs 128/180Linear / tracking
Risk / follow-ups
conv-47-q103James 9 July hobby (do not steal John's metal detecting). Do not chase camping-peaceful (conv-41-q145, not stored). Do not steal Deborah exploring for Jolene surf (conv-48-q124).gameglobally. Do not treat childhood comic-sketch desire as the current course project. Do not steal John’s FIFA or sibling coding.conv-48-q116remains.Notes
No API/contract change. No migration. Product SHA
9513039. Pin docs SHA9128a61. Ready for dest/main FF.