Skip to content

fix(recall): P39 dated reported-speech leftover covering (123/180) - #155

Merged
cursor[bot] merged 2 commits into
devfrom
pr/locomo-180-p39-1e9e
Aug 25, 2026
Merged

cursor[bot] merged 2 commits into
devfrom
pr/locomo-180-p39-1e9e

Conversation

@sdntsng

@sdntsng sdntsng commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

P38 pinned 122/180. One remaining WRONG was conv-43-q136 (What did Tim say about his injury on 16 November, 2023?). Gold is the attributed leftover The doctor said it's not too serious. It is stored in session_18 (recency 44/56) but is not they-evaluative and not first-person got, so P38 session expand never admitted it and /recall abstained.

This PR extends what-say-about leftover covering to dated queries: attributed leftover of the form the <role> said + copula (it's / it is / it was / it isn't) when the query names a calendar date. They-evaluative leftovers still win. Undated queries still use first-person got leftover and do not fall through to reported speech, so NYC It's got cannot steal doctor-said and dated injury queries cannot steal It's got.

Skip-ingest 180 locomo-s0-diag-mh-135-p39-product-recall-s1-771fc1 is 123/180 (+1/−0 vs P38). Product SHA b3d5752. Pin docs SHA is this commit. Search p50 188.5 ms. This is not n=1540, not a Mem0 same-pin, and not SOTA.

Changes

  • leftoverCoveringReportedSpeechLinethe <role> said it's … / it is / it was / it isn't. 5–16 words. Role is one lowercase alphabetic token, not a named dictionary. Rejects they-evaluative, first-person got, chat/interrogative/caption.
  • What-say-about covering: they-evaluative first; dated queries then reported-speech with object evidence on packet lines; undated queries then first-person got with object evidence. Fail-closed otherwise. No dated→got or undated→reported-speech fallthrough.
  • Session expand / floor / rank boost / hop-dump skip / hybrid skip / enumerate item sync use leftoverCoveringSayAboutTargetLine (they, got, or reported-speech).
  • Pin: locomo-s0-diag-mh-135-p39-20260825.md, summary JSON, failure ledger jsonl, README row, cycle-closeout 2026-08-25 — P39 dated reported-speech leftover covering (123/180), handover.

Test plan

  • gofmt clean on touched files
  • go vet ./internal/memory ./cmd/api
  • go test ./internal/memory (dated reported-speech covering, dated-skips-got, undated-skips-reported, NYC still got, session expand, search admit)
  • Live holds: NYC got, dancers, injury gold, writing/turtle/electronic/dinner/advice/veterans/push/smartwatch
  • Skip-ingest 180 --run-prefix locomo-s0-diag-mh-135-p39123/180 (MH 18/33, OD 4/11, SH 71/98, temporal 30/38). Ledger: RETRIEVAL 25 / PROOF 20 / READER 7 / WRITE 4 / HARNESS 1.

Linear / tracking

  • ENG-176 (MH) / parent ENG-168

Risk / follow-ups

  • Unique next is not Tim injury: dogs/snow (conv-44-q107, gold Confused vs current dislike snow). Gold is in store.
  • Do not chase camping-peaceful (conv-41-q145) — gold not stored.
  • Do not steal Deborah’s “connected to my body” for Jolene (conv-48-q116 harness timeout).
  • Do not add a doctor/injury dictionary. Do not reuse they-copula. Do not steal NYC It's got.
  • Goal remains 162/180. 123/180 is 39 short. Full n=1540 product /recall is still 175/1540 = 11.4%.
  • Fair Mem0 180 waits on quota reset 2026-09-01. Do not merge S1–S5 compiler/answer/alias/KU (split from mixed S0 PR) #133. Do not revive P29.
Open in Web Open in Cursor 

sdntsng and others added 2 commits August 25, 2026 14:13
Dated what-say-about leftover covering admits attributed leftover of
the form "The <role> said it's …" when another packet line covers the
object tokens. They-evaluative leftovers still win. Undated queries
still use first-person got leftover and do not fall through to
reported speech. Do not treat doctor-said as it's-got.

Co-authored-by: aria <aria@engramhq.com>
…/180

Skip-ingest 180 locomo-s0-diag-mh-135-p39-product-recall-s1-771fc1 is
123/180 (+1/-0 vs P38). Named recovery is conv-43-q136 Tim injury
doctor-said leftover. NYC It's-got and they-evaluative dancers held.
Not n=1540. Not a Mem0 same-pin.

Co-authored-by: aria <aria@engramhq.com>
@cursor cursor Bot changed the title fix(recall): P39 dated reported-speech leftover for what-say-about fix(recall): P39 dated reported-speech leftover covering (123/180) Aug 25, 2026
@sdntsng
sdntsng marked this pull request as ready for review August 25, 2026 14:27
@cursor
cursor Bot merged commit d2d913a into dev Aug 25, 2026
2 checks passed
@sdntsng
sdntsng deployed to dev - brainy-worker-staging August 25, 2026 14:27 — with Render Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant