fix(recall): P39 dated reported-speech leftover covering (123/180) - #155
Merged
Merged
Conversation
Dated what-say-about leftover covering admits attributed leftover of the form "The <role> said it's …" when another packet line covers the object tokens. They-evaluative leftovers still win. Undated queries still use first-person got leftover and do not fall through to reported speech. Do not treat doctor-said as it's-got. Co-authored-by: aria <aria@engramhq.com>
…/180 Skip-ingest 180 locomo-s0-diag-mh-135-p39-product-recall-s1-771fc1 is 123/180 (+1/-0 vs P38). Named recovery is conv-43-q136 Tim injury doctor-said leftover. NYC It's-got and they-evaluative dancers held. Not n=1540. Not a Mem0 same-pin. Co-authored-by: aria <aria@engramhq.com>
sdntsng
marked this pull request as ready for review
August 25, 2026 14:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P38 pinned 122/180. One remaining WRONG was
conv-43-q136(What did Tim say about his injury on 16 November, 2023?). Gold is the attributed leftoverThe doctor said it's not too serious. It is stored insession_18(recency 44/56) but is not they-evaluative and not first-person got, so P38 session expand never admitted it and/recallabstained.This PR extends what-say-about leftover covering to dated queries: attributed leftover of the form
the <role> said+ copula (it's/it is/it was/it isn't) when the query names a calendar date. They-evaluative leftovers still win. Undated queries still use first-person got leftover and do not fall through to reported speech, so NYCIt's gotcannot steal doctor-said and dated injury queries cannot stealIt's got.Skip-ingest 180
locomo-s0-diag-mh-135-p39-product-recall-s1-771fc1is 123/180 (+1/−0 vs P38). Product SHAb3d5752. Pin docs SHA is this commit. Search p50 188.5 ms. This is not n=1540, not a Mem0 same-pin, and not SOTA.Changes
leftoverCoveringReportedSpeechLine—the <role> said it's …/it is/it was/it isn't. 5–16 words. Role is one lowercase alphabetic token, not a named dictionary. Rejects they-evaluative, first-person got, chat/interrogative/caption.leftoverCoveringSayAboutTargetLine(they, got, or reported-speech).Test plan
gofmtclean on touched filesgo vet ./internal/memory ./cmd/apigo test ./internal/memory(dated reported-speech covering, dated-skips-got, undated-skips-reported, NYC still got, session expand, search admit)--run-prefix locomo-s0-diag-mh-135-p39→ 123/180 (MH 18/33, OD 4/11, SH 71/98, temporal 30/38). Ledger: RETRIEVAL 25 / PROOF 20 / READER 7 / WRITE 4 / HARNESS 1.Linear / tracking
Risk / follow-ups
conv-44-q107, goldConfusedvs currentdislike snow). Gold is in store.conv-41-q145) — gold not stored.conv-48-q116harness timeout).It's got./recallis still 175/1540 = 11.4%.