P34: what-kind like-list leftover covering (118/180) - #150
Merged
Merged
Conversation
What-kind leftover covering prefers like-A,-B,-and-C leftover over spread restatement. Bounded session-id fetch plus a search floor so zero-token leftover can rank. Does not drop spread. Does not add a food dictionary. Co-authored-by: aria <aria@engramhq.com>
First P34 180 dipped 116/180: when-event leftover covering admitted a like-A,-B,-and-C activity dump. Keep the dinner like-list exception only on what-kind queries. Co-authored-by: aria <aria@engramhq.com>
cursor
Bot
changed the title
Skip-ingest p34b 180 is 118/180 (+1/-0 vs P33). Dinner-spread like-list recovered. First P34 180 116/180 dip is not a pin. Co-authored-by: aria <aria@engramhq.com>
cursor
Bot
changed the title
sdntsng
marked this pull request as ready for review
August 25, 2026 10:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P34 admits like-A,-B,-and-C leftover on what-kind queries so Maria's dinner spread (
conv-41-q94) can beat a spreading-kindness restatement. Gold is stored in the dinner session with no food/dinner/spread tokens; FTS ANDsspreadagainst kindness speech.Pinned 118/180 (0.656) on skip-ingest
locomo-s0-diag-mh-135-p34b-product-recall-s1-187c30. Flip vs P33ebb36f: +1 / −0. Only gain: dinner spread. MH 18/33, OD 4/11, SH 66/98, temporal 30/38. Product SHA763a90a. Pin docs SHA482933a.First P34 180 (
cd644b, 116/180) is not a pin — a global like-list hop-dump exception let when-event leftover covering pick a comma activity dump on Joanna's letter.763a90agates that exception onlooksWhatKindQueryonly.Does not drop
spread. Does not add a food/salad dictionary.Changes
looksWhatKindQuery—what kind of. Destress, advice, host, and what-made stay out.like A, B, and Cleftover over spread/kind restatement; score +4 / −3.leftoverSkipLineskips crowded hop dumps except kind-list leftover on what-kind queries only. When-event covering still skips like-list activity dumps."it"soIt had lots…competes.sessionIDsForWhatKindQuery— n≥2 leftover tokens ignoring restatement tokens (spread/kind) so session_5 kindness is not fetched.expandKindListSessionNeighborscap 8. Search floor 0.9 (ranking_basis=kind_list_floor). Rank boost +0.75. Fact-primary keeps like-list episodes.Test plan
gofmt -lclean on touched filesgo test ./internal/memory— dinner like-list beats kindness; when-event letter prefers dated leftover over kind-list hop dumps; polar girlfriend covering stays empty--run-prefix locomo-s0-diag-mh-135-p34b118/180 net +1 vs 117/180 (ebb36f)Linear / tracking
Risk / follow-ups
conv-42-q108). Do not add a care→clean/feed/light dictionary. Do not dropturtles/care.spread. Do not add a food/salad dictionary./recallis still 175/1540 = 11.4% on SHA1b5ab3e. Fair Mem0 180 waits on quota 2026-09-01.