fix(recall): admit hortative leftover from advice-echo sessions (P33) - #149
Merged
Merged
Conversation
What-advice leftover omits the speech-act token, so FTS ANDs "advice" against the echo while gold sits in that session past the recency window. Fetch bounded rows for sessions that mention advice plus another leftover token; prefer hortative / first-person-gerund leftover over awesome restatement. Do not drop advice from search. Co-authored-by: aria <aria@engramhq.com>
Hortative leftover omits advice/business terms, so IDF score is 0 and fusion drops the line before the directive boost. Give those lines a search floor so they can enter host-query-style top-k. Co-authored-by: aria <aria@engramhq.com>
Skip-ingest S0 product /recall on frozen diag-mh-135 is 117/180 (+1/-0 vs P32). Named recovery: Gina advice (conv-30-q57). Co-authored-by: aria <aria@engramhq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P32 frozen pin was 116/180. Remaining SH miss
conv-30-q57(What advice does Gina give to Jon about running a successful business?) gold is build relationships with customers, create a strong brand image, stay positive.The gold leftover is stored in session_7 (recency rank ~827 / 1294, past the 400-row window) and has no advice/business/running tokens. FTS ANDs
adviceagainst the echo (Got any advice…,Thanks for the advice). Hybrid previously answered starting your own business sounds awesome.This increment (generic English, not a relationships/brand dictionary, do not drop
advice):Pinned skip-ingest 180: 117/180 (0.650) vs P32 116/180. Flip +1 / −0. Only gain:
conv-30-q57. Groups: MH 18/33, OD 4/11, SH 65/98, temporal 30/38. Ledger: RETRIEVAL 28 / PROOF 22 / READER 7 / WRITE 4 / HARNESS 2. Runlocomo-s0-diag-mh-135-p33-product-recall-s1-ebb36f. Product SHA097c6eb, pin docs SHAf61fdac.Live Gina advice:
Building relationships and creating a strong brand image for my store is something I'm always working on; Also be sure to build relationships with your customers – let them know you care; And don't forget to stay positive and motivate othersHolds: P32 veterans stories, P31 stuffed-animal, P30 push, P28 22/22.
Changes
internal/memory/recall.go: advice leftover covering, prefer/join hortative leftover, hybrid replace.internal/memory/service.go: advice-echo session fetch, directive rank floor + boost, keep hortative episodes.advice; IDF score is 0 without the floor.Test plan
gofmt+go vet ./internal/memory/+go test ./internal/memory/--run-prefix locomo-s0-diag-mh-135-p33vs P32becb9c9: 117/180, net +1Linear / tracking
097c6eb/ docsf61fdac) beats P32 116/180 (cd77a74/ docs67bac0b)Risk / follow-ups
advice. Do not drop May. Do not revive P29. Do not add a host→party or advice→brand dictionary.