Skip to content

fix(recall): admit hortative leftover from advice-echo sessions (P33) - #149

Merged
cursor[bot] merged 3 commits into
devfrom
pr/locomo-180-p33-1e9e
Aug 25, 2026
Merged

cursor[bot] merged 3 commits into
devfrom
pr/locomo-180-p33-1e9e

Conversation

@sdntsng

@sdntsng sdntsng commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

P32 frozen pin was 116/180. Remaining SH miss conv-30-q57 (What advice does Gina give to Jon about running a successful business?) gold is build relationships with customers, create a strong brand image, stay positive.

The gold leftover is stored in session_7 (recency rank ~827 / 1294, past the 400-row window) and has no advice/business/running tokens. FTS ANDs advice against the echo (Got any advice…, Thanks for the advice). Hybrid previously answered starting your own business sounds awesome.

This increment (generic English, not a relationships/brand dictionary, do not drop advice):

  1. Detect what/how + advice/advise queries.
  2. Rank leftover-covering candidate sessions that actually mention the speech-act token plus another leftover token (campaign sessions without an advice echo are not fetched).
  3. Bounded session-id fetch; admit hortative / first-person-gerund leftover that omits the speech-act/business restatement tokens.
  4. Search floor + rank boost so zero-token leftover can enter top-k; leftover covering joins up to three of those lines over an awesome restatement.
  5. Keep hortative episode primitives on advice queries.

Pinned skip-ingest 180: 117/180 (0.650) vs P32 116/180. Flip +1 / −0. Only gain: conv-30-q57. Groups: MH 18/33, OD 4/11, SH 65/98, temporal 30/38. Ledger: RETRIEVAL 28 / PROOF 22 / READER 7 / WRITE 4 / HARNESS 2. Run locomo-s0-diag-mh-135-p33-product-recall-s1-ebb36f. Product SHA 097c6eb, pin docs SHA f61fdac.

Live Gina advice: Building relationships and creating a strong brand image for my store is something I'm always working on; Also be sure to build relationships with your customers – let them know you care; And don't forget to stay positive and motivate others

Holds: P32 veterans stories, P31 stuffed-animal, P30 push, P28 22/22.

Changes

  • internal/memory/recall.go: advice leftover covering, prefer/join hortative leftover, hybrid replace.
  • internal/memory/service.go: advice-echo session fetch, directive rank floor + boost, keep hortative episodes.
  • Tests: covering vs awesome/students/business-restatement; session pick requires advice echo; lexical search still keeps advice; IDF score is 0 without the floor.
  • Pin: locomo-s0-diag-mh-135-p33-20260825.md, cycle-closeout P33 section, handover, benchmarks README.

Test plan

  • gofmt + go vet ./internal/memory/ + go test ./internal/memory/
  • Live Gina advice cites relationships and brand and stay positive (not awesome, not advice echo)
  • Holds: P32 veterans stories, P31 stuffed-animal, P30 push, P28 22/22
  • Skip-ingest 180 --run-prefix locomo-s0-diag-mh-135-p33 vs P32b ecb9c9: 117/180, net +1

Linear / tracking

  • ENG-176 / ENG-168
  • Frozen pin: P33 117/180 (097c6eb / docs f61fdac) beats P32 116/180 (cd77a74 / docs 67bac0b)

Risk / follow-ups

  • Do not drop advice. Do not drop May. Do not revive P29. Do not add a host→party or advice→brand dictionary.
  • 117/180 is not 80% (144) and not 90% (162). Next ranking miss with gold in store: turtle-care / Joanna writing / dinner spread. No n=1540. No LME-500. No SOTA.
  • WRITE still 4 — do not merge S1–S5 compiler/answer/alias/KU (split from mixed S0 PR) #133.
Open in Web Open in Cursor 

sdntsng and others added 3 commits August 25, 2026 09:55
What-advice leftover omits the speech-act token, so FTS ANDs "advice"
against the echo while gold sits in that session past the recency window.
Fetch bounded rows for sessions that mention advice plus another leftover
token; prefer hortative / first-person-gerund leftover over awesome
restatement. Do not drop advice from search.

Co-authored-by: aria <aria@engramhq.com>
Hortative leftover omits advice/business terms, so IDF score is 0 and
fusion drops the line before the directive boost. Give those lines a
search floor so they can enter host-query-style top-k.

Co-authored-by: aria <aria@engramhq.com>
Skip-ingest S0 product /recall on frozen diag-mh-135 is 117/180
(+1/-0 vs P32). Named recovery: Gina advice (conv-30-q57).

Co-authored-by: aria <aria@engramhq.com>
@sdntsng
sdntsng marked this pull request as ready for review August 25, 2026 10:13
@cursor
cursor Bot merged commit f61fdac into dev Aug 25, 2026
2 checks passed
@sdntsng
sdntsng deployed to dev - brainy-worker-staging August 25, 2026 10:13 — with Render Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant