fix(search): how-describe lexical admit (P31, 115/180) - #147
Merged
Merged
Conversation
How-does-X-describe-Y leftover lines are first-person and omit the name. Compiler "X describes Y" stamps plus person ILIKE flood the candidate pool, so stuffed-animal gold never enters top-k. Drop describe* and capitalized person tokens when other object tokens remain. Gate filtered admit/covering to what-made and how-describe only. Co-authored-by: aria <aria@engramhq.com>
Keeping got ILIKE-floods the stuffed/object pool (76 hits) so first-person gold never enters top-k. Drop got/gets after person filtering so object tokens (stuffed, animal) remain and the 22-hit pool fits in the packet. Co-authored-by: aria <aria@engramhq.com>
Skip-ingest p31b 115/180 (+1 stuffed-animal / -0 vs P30). First p31 180 was 114/180 net 0 from a James-girlfriend hybrid flake; not a pin. Co-authored-by: aria <aria@engramhq.com>
sdntsng
marked this pull request as ready for review
August 25, 2026 08:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P30 frozen pin was 114/180. Remaining SH miss
conv-42-q123(How does Nate describe the stuffed animal he got for Joanna?) stores gold as a first-person leftover (It's a stuffed animal to remind you of the good vibes) but live/recallnever admitted it. CompilerNate describes Ystamps plus person ILIKE flooded the pool; keepinggotthen ILIKE-flooded to 76 hits (gold recency 12 in the 22-hit stuffed|animal pool).This increment is the same generic English mechanism as P30, for how-does/did/do-X-describe-Y queries: drop
describe*structure tokens, drop capitalized person tokens when other object tokens remain, dropgot/getsafter person filtering, and gate filtered token-admit / related-fact / evidence-set covering to what-made or how-describe. Destress, instrument-purpose, and which-year covering stay on the unfiltered token set.Pin: skip-ingest
locomo-s0-diag-mh-135-p31b-product-recall-s1-909042is 115/180 (0.639), +1 / −0 vs P30. Named recovery: stuffed-animal good vibes. MH 18 / OD 4 / SH 63 / temporal 30. First P31 180 (a6117e) was 114/180 net 0 (girlfriend hybridnot in memoryflake) and is not a pin.Not a LoCoMo-named product rule. Do not drop Joanna from all search. Do not drop
advice. Turtle-care and camping-peaceful golds did not recover (no turtle/care tokens; peaceful not stored).Changes
internal/memory/recall.go:looksHowDescribeQuery/looksFirstPersonLeftoverQuery. Destress and instrument-purpose are not how-describe.internal/memory/service.go: dropdescribe*from lexical tokens; reuse person-token filter for first-person leftover queries; dropgotafter person filter; gate filtered admit/covering to what-made and how-describe.describe/nate/joanna/gotand keepsstuffed/animal; destress keeps Melanie; what-made P30 test still holds.Test plan
gofmtclean on touched filesgo test ./internal/memory/andgo test ./.../go vet ./...gold_rank=9)p31114/180 net 0 (not a pin)p31b115/180 net +1 vs P30 — pinLinear / tracking
98d8931/ docs86d2a65)Risk / follow-ups
advice), veterans party (do not drop May), Joanna writing.