Skip to content

fix(search): how-describe lexical admit (P31, 115/180) - #147

Merged
cursor[bot] merged 3 commits into
devfrom
pr/locomo-180-p31-1e9e
Aug 25, 2026
Merged

cursor[bot] merged 3 commits into
devfrom
pr/locomo-180-p31-1e9e

Conversation

@sdntsng

@sdntsng sdntsng commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

P30 frozen pin was 114/180. Remaining SH miss conv-42-q123 (How does Nate describe the stuffed animal he got for Joanna?) stores gold as a first-person leftover (It's a stuffed animal to remind you of the good vibes) but live /recall never admitted it. Compiler Nate describes Y stamps plus person ILIKE flooded the pool; keeping got then ILIKE-flooded to 76 hits (gold recency 12 in the 22-hit stuffed|animal pool).

This increment is the same generic English mechanism as P30, for how-does/did/do-X-describe-Y queries: drop describe* structure tokens, drop capitalized person tokens when other object tokens remain, drop got/gets after person filtering, and gate filtered token-admit / related-fact / evidence-set covering to what-made or how-describe. Destress, instrument-purpose, and which-year covering stay on the unfiltered token set.

Pin: skip-ingest locomo-s0-diag-mh-135-p31b-product-recall-s1-909042 is 115/180 (0.639), +1 / −0 vs P30. Named recovery: stuffed-animal good vibes. MH 18 / OD 4 / SH 63 / temporal 30. First P31 180 (a6117e) was 114/180 net 0 (girlfriend hybrid not in memory flake) and is not a pin.

Not a LoCoMo-named product rule. Do not drop Joanna from all search. Do not drop advice. Turtle-care and camping-peaceful golds did not recover (no turtle/care tokens; peaceful not stored).

Changes

  • internal/memory/recall.go: looksHowDescribeQuery / looksFirstPersonLeftoverQuery. Destress and instrument-purpose are not how-describe.
  • internal/memory/service.go: drop describe* from lexical tokens; reuse person-token filter for first-person leftover queries; drop got after person filter; gate filtered admit/covering to what-made and how-describe.
  • Tests: stuffed-animal query drops describe/nate/joanna/got and keeps stuffed/animal; destress keeps Melanie; what-made P30 test still holds.
  • Pin docs: locomo-s0-diag-mh-135-p31-20260825.md, cycle-closeout, handover.

Test plan

  • gofmt clean on touched files
  • go test ./internal/memory/ and go test ./... / go vet ./...
  • Live q123 hybrid cites good vibes / remind (gold_rank=9)
  • How-describe holds: snake under bed, island, kayaking sunset, electronic elements
  • P30 q138 still cites push; P28 22/22 including health-year 2021, destress pottery, paint Saturday, Boston, renovate 2022, smartwatch enumerate reminder, girlfriend live hold
  • First 180 p31 114/180 net 0 (not a pin)
  • Skip-ingest 180 p31b 115/180 net +1 vs P30 — pin

Linear / tracking

Risk / follow-ups

Open in Web Open in Cursor 

sdntsng and others added 3 commits August 25, 2026 08:14
How-does-X-describe-Y leftover lines are first-person and omit the name.
Compiler "X describes Y" stamps plus person ILIKE flood the candidate
pool, so stuffed-animal gold never enters top-k. Drop describe* and
capitalized person tokens when other object tokens remain. Gate filtered
admit/covering to what-made and how-describe only.

Co-authored-by: aria <aria@engramhq.com>
Keeping got ILIKE-floods the stuffed/object pool (76 hits) so first-person
gold never enters top-k. Drop got/gets after person filtering so object
tokens (stuffed, animal) remain and the 22-hit pool fits in the packet.

Co-authored-by: aria <aria@engramhq.com>
Skip-ingest p31b 115/180 (+1 stuffed-animal / -0 vs P30). First p31 180
was 114/180 net 0 from a James-girlfriend hybrid flake; not a pin.

Co-authored-by: aria <aria@engramhq.com>
@cursor cursor Bot changed the title fix(search): how-describe lexical admit (P31) fix(search): how-describe lexical admit (P31, 115/180) Aug 25, 2026
@sdntsng
sdntsng marked this pull request as ready for review August 25, 2026 08:44
@cursor
cursor Bot merged commit 86d2a65 into dev Aug 25, 2026
2 checks passed
@sdntsng
sdntsng deployed to dev - brainy-worker-staging August 25, 2026 08:44 — with Render Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant