fix(recall): drop when-event speech-act flood; prefer dual-entity covering - #142
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When-event search was matching leftover-weak speech-act tokens (
decide/year) so dated dual-entity plans never entered the top packet. Live store hasSam plans to paint with Evan on Saturday, 16 September 2023at rank ~18 forEvan Sam paint together, but the originalWhen did … decide to paint together?query never retrieved it (flooded bySam decided … health changes).Skip-ingest 180 pin: 112/180 (0.622), +1 / −0 vs P25 111/180. Temporal 29→30. Named recovery:
conv-49-q53Saturday 16 September paint plan. MH/OD/SH held 18/4/60. Ledger READER 9→8; WRITE held 4.Generic ranking: for
when/ which-year queries, drop leftover-weak tokens from ILIKE + lexical scoring when another event noun remains. Leftover covering treatsdecide/decided/decidingas weak and adds a dual-entity score bonus so a line that names both query people beats a solo-painter dated dump. Does not require both people (McGee's still names John only).Does not name LoCoMo. Does not merge #133.
"destress"stays denylisted. Does not replace README 11.4% / 70% 1×30.Standing owner approval: FF dest and main after a net-positive 180.
Changes
internal/memory/service.go—searchLexicalTokens/searchDropsWeakEventTokensinternal/memory/recall.go— leftover weakdecide*; dual-entity leftover covering bonusTestSearchWhenEventDropsDecideFlood,TestSearchLexicalTokensDropsDecideWhenEventRemains,TestLeftoverCoveringWhenEventPrefersBothQueryPeoplelocomo-s0-diag-mh-135-p26-product-recall-s1-80549a). Product SHAe5ac883. Cycle-closeout 2026-08-25 — P26.Test plan
gofmt -lcleango test ./internal/memory/(full package)go vet ./internal/memory/ ./cmd/api ./cmd/worker/recallprobes: 0/27 fails (paint-together Saturday gain + P25 holds including health-year 2021, art-show April, community-center 2022, August teammates, destress pottery, Boston, McGee's, James girlfriend April 2022)--run-prefix locomo-s0-diag-mh-135-p26vs P25732148: 112/180, gainedconv-49-q53, lost noneLinear / tracking
Risk / follow-ups