Skip to content

fix(recall): drop when-event speech-act flood; prefer dual-entity covering - #142

Merged
cursor[bot] merged 0 commit into
devfrom
pr/locomo-180-p26-1e9e
Aug 25, 2026
Merged

cursor[bot] merged 0 commit into
devfrom
pr/locomo-180-p26-1e9e

Conversation

@sdntsng

@sdntsng sdntsng commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

When-event search was matching leftover-weak speech-act tokens (decide / year) so dated dual-entity plans never entered the top packet. Live store has Sam plans to paint with Evan on Saturday, 16 September 2023 at rank ~18 for Evan Sam paint together, but the original When did … decide to paint together? query never retrieved it (flooded by Sam decided … health changes).

Skip-ingest 180 pin: 112/180 (0.622), +1 / −0 vs P25 111/180. Temporal 29→30. Named recovery: conv-49-q53 Saturday 16 September paint plan. MH/OD/SH held 18/4/60. Ledger READER 9→8; WRITE held 4.

Generic ranking: for when / which-year queries, drop leftover-weak tokens from ILIKE + lexical scoring when another event noun remains. Leftover covering treats decide/decided/deciding as weak and adds a dual-entity score bonus so a line that names both query people beats a solo-painter dated dump. Does not require both people (McGee's still names John only).

Does not name LoCoMo. Does not merge #133. "destress" stays denylisted. Does not replace README 11.4% / 70% 1×30.

Standing owner approval: FF dest and main after a net-positive 180.

Changes

  • internal/memory/service.gosearchLexicalTokens / searchDropsWeakEventTokens
  • internal/memory/recall.go — leftover weak decide*; dual-entity leftover covering bonus
  • Tests: TestSearchWhenEventDropsDecideFlood, TestSearchLexicalTokensDropsDecideWhenEventRemains, TestLeftoverCoveringWhenEventPrefersBothQueryPeople
  • Pin: locomo-s0-diag-mh-135-p26-20260825.md (locomo-s0-diag-mh-135-p26-product-recall-s1-80549a). Product SHA e5ac883. Cycle-closeout 2026-08-25 — P26.

Test plan

  • gofmt -l clean
  • go test ./internal/memory/ (full package)
  • go vet ./internal/memory/ ./cmd/api ./cmd/worker
  • Live /recall probes: 0/27 fails (paint-together Saturday gain + P25 holds including health-year 2021, art-show April, community-center 2022, August teammates, destress pottery, Boston, McGee's, James girlfriend April 2022)
  • Skip-ingest 180 --run-prefix locomo-s0-diag-mh-135-p26 vs P25 732148: 112/180, gained conv-49-q53, lost none

Linear / tracking

  • ENG-176 (MH), parent ENG-168.

Risk / follow-ups

  • Isolated leftover covering is saturating. Remaining mass is SH PROOF 20 + RETRIEVAL 28. Remaining gold often is not a stored fact (Jolene yoga 2020, Phuket, Wolves).
  • 112/180 is not 80% (144) and not 90% (162).
  • Fair Mem0 180 waits on quota 2026-09-01.
  • OpMem 13/13 and marketing 17/17 last pin not re-run this increment.
Open in Web Open in Cursor 

@cursor
cursor Bot merged commit 9905c79 into dev Aug 25, 2026
2 checks passed
@sdntsng
sdntsng deployed to dev - brainy-worker-staging August 25, 2026 05:13 — with Render Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant