fix(recall): do not treat sentence-initial verbs as leftover people - #140
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P23 is on dest and main (
1d86b66/ producte05c78f, 109/180). P24 stops leftover when-event covering from treating a capitalized sentence-initial verb as a foreign person, so unnamed dated diary lines can still compete.Skip-ingest 180 on frozen
diag-mh-135(locomo-s0-diag-mh-135-p24-product-recall-s1-139aa5) is 110/180 (0.611) — +1 / −0 vs P23. Temporal 27→28. Named recovery: unnamed dated art-show diaryconv-48-q44(Checked out an art show with a friend today - really cool and inspiring stuff (9 April 2023)over hop date23 January 2023). Community-center and August teammates held.The product change is generic. It does not name LoCoMo. Named other people still drop covering. Short names stay people. Product SHA
80669d8; pin docs SHA follows this PR.This is not 80% (144/180), not 90% (162/180), not n=1540, not a Mem0 same-pin, and not SOTA. Does not replace README 11.4% / 70% 1×30.
Changes
leftoverCoveringSentenceInitialVerb: sentence-initial past-tense morphology (…ed, length ≥ 6) or a phrasal particle (out/up/off/down/away/back) is not a leftover covering person.leftoverCoveringLineHasForeignPersonskips those tokens.Checked out an art show… (9 April 2023)covers a when-event query; hop date / foreign movie / bereavement do not.Test plan
gofmtclean on touched filesgo test ./internal/memory/ -run TestLeftoverCoveringgo vet ./internal/memory/ ./cmd/api ./cmd/worker--run-prefix locomo-s0-diag-mh-135-p24→ 110/180Linear / tracking
Risk / follow-ups