Skip to content

fix(recall): do not treat sentence-initial verbs as leftover people - #140

Merged
cursor[bot] merged 0 commit into
devfrom
pr/locomo-180-p24-1e9e
Aug 25, 2026
Merged

cursor[bot] merged 0 commit into
devfrom
pr/locomo-180-p24-1e9e

Conversation

@sdntsng

@sdntsng sdntsng commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

P23 is on dest and main (1d86b66 / product e05c78f, 109/180). P24 stops leftover when-event covering from treating a capitalized sentence-initial verb as a foreign person, so unnamed dated diary lines can still compete.

Skip-ingest 180 on frozen diag-mh-135 (locomo-s0-diag-mh-135-p24-product-recall-s1-139aa5) is 110/180 (0.611)+1 / −0 vs P23. Temporal 27→28. Named recovery: unnamed dated art-show diary conv-48-q44 (Checked out an art show with a friend today - really cool and inspiring stuff (9 April 2023) over hop date 23 January 2023). Community-center and August teammates held.

The product change is generic. It does not name LoCoMo. Named other people still drop covering. Short names stay people. Product SHA 80669d8; pin docs SHA follows this PR.

This is not 80% (144/180), not 90% (162/180), not n=1540, not a Mem0 same-pin, and not SOTA. Does not replace README 11.4% / 70% 1×30.

Changes

  • leftoverCoveringSentenceInitialVerb: sentence-initial past-tense morphology (…ed, length ≥ 6) or a phrasal particle (out / up / off / down / away / back) is not a leftover covering person.
  • leftoverCoveringLineHasForeignPerson skips those tokens.
  • Test: dated Checked out an art show… (9 April 2023) covers a when-event query; hop date / foreign movie / bereavement do not.
  • Pin: docs/benchmarks/artifacts/locomo-s0-diag-mh-135-p24-20260825.md, cycle-closeout 2026-08-25 — P24, handover, README pin row.

Test plan

  • gofmt clean on touched files
  • go test ./internal/memory/ -run TestLeftoverCovering
  • go vet ./internal/memory/ ./cmd/api ./cmd/worker
  • Live probes: art-show April, community-center 2022, August teammates, P23 holds (destress, Boston, Jon banker, yoga locations) — 0/25 fails
  • Skip-ingest 180 --run-prefix locomo-s0-diag-mh-135-p24110/180
  • Pin (handwritten md + summary.json + jsonl only). FF dest and main next.

Linear / tracking

  • ENG-176
  • ENG-168

Risk / follow-ups

Open in Web Open in Cursor 

@cursor
cursor Bot merged commit 6743a88 into dev Aug 25, 2026
2 checks passed
@sdntsng
sdntsng deployed to dev - brainy-worker-staging August 25, 2026 04:29 — with Render Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant