fix(recall): let year-dated when-event leftover replace bare hop dates - #139
Merged
Merged
Conversation
When-event leftover covering skipped year-only event facts because BareDateMissesEvent required parseDateFromText on the covering line. A hop calendar date then locked out a packet fact that named the event and a year. Require a year/date token on when-event covering lines, and treat a year token as enough covering date. Co-authored-by: aria <aria@engramhq.com>
P23's year-token covering gate recovered community-center 2022 but let a 2022 team-game leftover cover an August 2023 meetup (teammates~team). If the query names a year, covering lines from a different year no longer compete. Co-authored-by: aria <aria@engramhq.com>
Year match was not enough: an October 2023 team-trip leftover still covered an August 2023 meetup. If the query names a month, covering lines from a different month no longer compete. Co-authored-by: aria <aria@engramhq.com>
Skip-ingest 180 on frozen diag-mh-135 is 109/180 (+1 / -0 vs P22). Temporal 26→27. Named recovery: hometown community-center 2022 over a bare hop date. First P23 180 108/180 hold (August teammates dip) is not a pin. Co-authored-by: aria <aria@engramhq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P22 is on dest and main (
2287726/ product9d50bad, 108/180). P23 lets year-dated when-event leftover facts replace a bare hop calendar date, then skips covering whose year or month disagrees with the query.Skip-ingest 180 on frozen
diag-mh-135(locomo-s0-diag-mh-135-p23c-product-recall-s1-f3f3be) is 109/180 (0.606) — +1 / −0 vs P22. Temporal 26→27. Named recovery: hometown community-center yearconv-41-q53(John helped renovate a rundown community center back home in 2022.over hop date17 July 2023). August teammatesconv-43-q91held.First P23 180 (
…-p23-…-f9b076) was a 108/180 hold (+1 community center / −1 August teammates viateammates~team) and is not a pin.The product change is generic. It does not name LoCoMo and does not expand
looksWhenEventQuery. Product SHAe05c78f; pin docs SHA follows this PR.This is not 80% (144/180), not 90% (162/180), not n=1540, not a Mem0 same-pin, and not SOTA. Does not replace README 11.4% / 70% 1×30.
Changes
leftoverCoveringBareDateMissesEventtreats a year token as enough covering date.leftoverCoveringSkipYearMismatch: if the query names a year or month, covering from a different year/month does not compete.17 July 2023; August 2023 meetup covers; 2022 buzzer-beater and October 2023 team trip do not.Test plan
go test ./internal/memory/--run-prefix locomo-s0-diag-mh-135-p23c→ 109/180Linear / tracking
Risk / follow-ups
Checked out…).