fix(recall): bind leftover covering to query month when tokens collapse - #138
Merged
Merged
Conversation
Activity questions that name people and a month were left with only weak covering tokens (activity/together/plan). Rarest-token override then picked generic pep-talk over a dated co-participant plan. Keep the query month or year as the bind token in that collapse, and never rarest-override on weak tokens. Co-authored-by: aria <aria@engramhq.com>
Skip-ingest 180 on frozen diag-mh-135 is 108/180 (+1 / -0 vs P21). Temporal 25→26. Named recovery: September co-participant plan over activity pep-talk. Co-authored-by: aria <aria@engramhq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P21 is already on dest and main (
36f39c2/ productfa915fe, 107/180). P22 is a net-positive skip-ingest 180 pin: 108/180 (0.600) on product SHA9d50bad(pin docs2287726).Leftover covering for activity questions that name people and a month was collapsing to weak tokens (
activity/together/plan). The rarest-token override then picked generic pep-talk (keep going and have fun) over a dated co-participant plan already in the leftover packet.The product change is generic. It does not name LoCoMo, does not special-case painting vs kayaking, and does not expand
looksWhenEventQuery.Changes
leftoverCoveringRareForQuery: when leftover tokens are weak-only after entity/calendar stripping, bind covering to the query month (or year if there is no month).leftoverCoverRarestTokens: never rarest-override on weak tokens such asactivity.Test plan
gofmt -lclean on touched filesgo test ./internal/memory/(includes new dated-plan leftover covering fixture)go vet ./internal/memory/ ./cmd/api ./cmd/worker/tmp/brainy-api(BRAINY_RECALL_LLM=1). Live holds: yoga locations, destress pottery, Boston garage, Jon banker, McGee's, Ned, childhood items, Max, Thanksgiving, Toronto, basketball, chili+ring-toss, UK, Shadow, Gina internship, first-console, horseback, letter, Caroline biking, James girlfriend April 2022 — 0 hold fails. Gain: September paint plan is live on/recall(probe flagged kayaking leftover onitemsonly; 180 harness is answer-mode).--run-prefix locomo-s0-diag-mh-135-p22on frozendiag-mh-135: 108/180, flips +1 / −0 vs P21 (conv-49-q52). Temporal 25→26. READER 12→11.Linear / tracking
Risk / follow-ups