Skip to content

add hashing for saveing document data, fixed current tab not getting focused on session restore#423

Open
aryanchoudharypro wants to merge 2 commits intotrypsynth:masterfrom
aryanchoudharypro:enhancements
Open

add hashing for saveing document data, fixed current tab not getting focused on session restore#423
aryanchoudharypro wants to merge 2 commits intotrypsynth:masterfrom
aryanchoudharypro:enhancements

Conversation

@aryanchoudharypro
Copy link
Copy Markdown
Contributor

closes #420

@trypsynth
Copy link
Copy Markdown
Owner

Nice work on this! It definitely solves the rename issue, but I'm a bit worried about it chugging on the first run. Since the migration hashes everything at once in the config loader, anyone with a big library is going to hit a massive hang on first startup. Also, if a file is missing, it falls back to hashing the path string. That means if I move a file while the app is closed, the IDs won't match and the bookmarks are still lost anyway. It'd be safer to compute these hashes lazily and store them permanently in the config so you aren't hitting the disk every time doc_key is called. Also, heads up that you're using Base64 in one spot and Hex in another; probably worth picking one and sticking to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't use the file name and path for bookmarks and stored positions

2 participants