add hashing for saveing document data, fixed current tab not getting focused on session restore#423
Open
aryanchoudharypro wants to merge 2 commits intotrypsynth:masterfrom
Open
Conversation
…focused on session restore
Owner
|
Nice work on this! It definitely solves the rename issue, but I'm a bit worried about it chugging on the first run. Since the migration hashes everything at once in the config loader, anyone with a big library is going to hit a massive hang on first startup. Also, if a file is missing, it falls back to hashing the path string. That means if I move a file while the app is closed, the IDs won't match and the bookmarks are still lost anyway. It'd be safer to compute these hashes lazily and store them permanently in the config so you aren't hitting the disk every time doc_key is called. Also, heads up that you're using Base64 in one spot and Hex in another; probably worth picking one and sticking to it! |
e775dd1 to
b0e3a71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #420