Repository navigation
Say the volume as soon as it changes - #451
Open
nibarAhmed wants to merge 1 commit into
Open
nibarAhmed wants to merge 1 commit into
nibarAhmed wants to merge 1 commit into
Conversation
TalkBack waited until the volume keys had been still for 2 seconds, and didn't say the media volume while media played. Backtalk now says each new level right away, says a held key's level when it's released, keeps changes that aren't the user's quiet, such as the level headphones bring when they connect, and nudges the accessibility volume on Bluetooth so the announcement plays at the new level. "Backtalk off" is said at the accessibility volume on Samsung phones and on each output. Fixes trypsynth#295 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nibarAhmed
force-pushed
the
speak-volume-right-away
branch
from
November 8, 2026 23:19
5ca1252 to
8979dc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TalkBack waited until the volume keys had been still for 2 seconds before saying the volume, and it didn't say the media volume while media played. That made the volume keys feel slow. On Bluetooth headphones the announcement could also come out louder or quieter than the speech after it, and connecting headphones could make Backtalk read out the level they brought with them.
Now Backtalk says the new volume as soon as it changes:
The volume code moved out of Google's
VolumeMonitorintoVolumeAnnouncerandQuietBeforeAnnouncement, so Google's Java files only get small hooks.differences.mddescribes the new behaviour.Fixes #295. The issue's optional sound cues instead of speech are left out.
Testing
VolumeMonitorTest,QuietBeforeAnnouncementTest,FinalAnnouncementVolumeTest).Created with Claude Opus 5.5 in Claude Code, through T3 Code.
🤖 Generated with Claude Code