chore(deps): jsdom 30, jest-dom 7, eventsource-parser 4 - #436
Merged
Merged
Conversation
Clears three Dependabot majors in one lockfile change. Dependabot opened
these as separate PRs, but all three touch `bun.lock`, so merging any one
of them conflicts the other two — and two of its branches never got a
lockfile commit at all, which is why their `bun install --frozen-lockfile`
step failed.
- `jsdom` 29.1.1 -> 30.0.1 (web tests)
- `@testing-library/jest-dom` 6.10.0 -> 7.0.0 (web tests)
- `eventsource-parser` 3.1.1 -> 4.1.0 (cli runtime)
`eventsource-parser` v4 keeps the surface `packages/cli/src/lib/sse.ts`
uses — `createParser({ onEvent })`, `feed()`, and the `EventSourceMessage`
type — so the bump is lockfile-only.
Also declares `@testing-library/dom` ^10.4.0 in `packages/web`. It was
never declared anywhere and sat at 9.3.4 as an unmet peer, already wrong
for `@testing-library/react` 16 (which wants ^10.0.0); jest-dom 7 tightened
its own range to `>=10 <11` and surfaced it as an install warning. Declaring
it is what makes the peer graph honest rather than silently satisfied by a
stale hoist.
Closes #412
Closes #406
Closes #427
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vck5KSX2CLxhohx14nb5Sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears three Dependabot majors in one lockfile change, superseding #412, #406 and #427.
Why one PR
All three bumps touch
bun.lock, so merging any one of them conflicts the other two. Two of them (#427, #350) were also red for the same mechanical reason: Dependabot bumpedpackage.jsonbut never pushed abun.lockupdate, so CI'sbun install --frozen-lockfilefailed withlockfile had changes, but lockfile is frozen. Doing them together regenerates the lockfile once and pays CI once.What's in it
jsdom@testing-library/jest-domeventsource-parsereventsource-parserwas the only one touching runtime code. v4 keeps the surfacepackages/cli/src/lib/sse.tsuses —createParser({ onEvent }),feed(), and theEventSourceMessagetype — so it's lockfile-only, and typecheck confirms it.One thing beyond the bumps
@testing-library/domis now declared explicitly inpackages/webat^10.4.0.It was declared nowhere and sat at 9.3.4 as an unmet peer. That was already wrong before this PR —
@testing-library/react@16.3.2wants^10.0.0— but nothing surfaced it. jest-dom 7 tightened its own peer to>=10 <11, which turned it into an install warning. Declaring it is what makes the peer graph honest rather than quietly satisfied by a stale hoisted resolution. Web tests pass on v10 (276 across 49 files), so nothing was relying on v9 behavior.Test evidence
Run locally on this branch:
bun run typecheck— all 6 packages cleanbun run lint— all 6 packages cleanbun run test— 780 server tests pass (2218 assertions, 87 files), 276 web tests pass (49 files), 0 failuresbun run build— all packages builtNot included
#350 (typescript 6.0.3 → 7.0.2) is deliberately left out. It's a compiler swap across all five packages rather than a test-only or lockfile-only change, and it deserves its own PR and its own CI run rather than riding along and blocking three bumps that are ready. It stays open.
Closes #412
Closes #406
Closes #427
🤖 Generated with Claude Code
https://claude.ai/code/session_01Vck5KSX2CLxhohx14nb5Sh