Conversation
…on fields The workflow has never been able to run. It looks for `packages/<name>/package.json`, but apps live in `src/<name>/` — so the "Verify package exists" step fails for every input, on every app in the catalog. Nothing caught it because the trigger is workflow_dispatch only. Fixing the path alone would leave it half-right. Each app carries its version in two places that must agree: build-catalog.sh publishes the OCI tag from package.json, while the Hola server shows the one in manifest.json. Bumping only package.json ships a bundle advertising a version it wasn't published under. Both are now updated in lockstep, and a package whose two versions already disagree is refused rather than reconciled by guesswork — picking a winner silently is how they'd drift further. Also drops the setup-node step: it was there "for the jq command", which jq doesn't need — jq is preinstalled on ubuntu-latest, and nothing else in the job runs Node. Verified: the YAML parses, a minor bump moves both files 2.0.0 -> 2.1.0, and the mismatch guard fires on a desynced pair. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Independent of the
#418contract stack (#142–#145) — found while working through it.The bug
version-bump.ymlhas never been able to run. It looks forpackages/<name>/package.json, but apps live insrc/<name>/, so the Verify package exists step fails for every input, on every app in the catalog. Nothing caught it because the trigger isworkflow_dispatchonly.Why the path fix alone isn't enough
Each app carries its version in two places that have to agree:
bin/build-catalog.shpublishes the OCI tag frompackage.json;manifest.json.Bumping only
package.json— which is all the workflow ever tried to do — ships a bundle advertising a version it wasn't published under. Both are now updated in lockstep.A package whose two versions already disagree is refused rather than reconciled: guessing which one is authoritative would silently pick a winner and let them drift further. The error says which is which and asks for a manual fix.
Also
Drops the
setup-nodestep. Its comment said it was needed "for the jq command" — jq doesn't need Node, it's preinstalled onubuntu-latest, and nothing else in the job runs Node.Testing
workflow_dispatch-only workflows can't be exercised from a PR, so I ran the logic directly: the YAML parses, a minor bump moves both files2.0.0 → 2.1.0, and the mismatch guard fires on a deliberately desynced pair.🤖 Generated with Claude Code