docs(extension): document inline sign-in prompt for signed-out state#593
Draft
samgutentag wants to merge 1 commit intomainfrom
Draft
docs(extension): document inline sign-in prompt for signed-out state#593samgutentag wants to merge 1 commit intomainfrom
samgutentag wants to merge 1 commit intomainfrom
Conversation
The extension now renders a "Sign in to Trunk" row in the PR panel when the Trunk session is signed out, replacing the previous silent behavior. Update the auth description and the troubleshooting FAQ accordingly. Source: trunk2 PR #3815 Linear: TRUNK-18155 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Contributor
|
Claude finished @samgutentag's task in 41s —— View job Review
The changes are clear and well-structured. The updated session-based auth description and the reordered FAQ troubleshooting steps are both improvements. One minor grammar fix to note:
Missing comma after the introductory clause — should be: Everything else looks good — accurate, appropriately specific, and consistent with the surrounding doc style. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| The extension does **not** ask you for credentials, API tokens, or a separate password. It authenticates by reusing your existing browser session at [app.trunk.io](https://app.trunk.io/) — the same session you already use for the Trunk web app. | ||
|
|
||
| * **Session-based auth.** When you take an action in the extension, the request is sent to the Trunk API with the cookies your browser already holds for `app.trunk.io`. If you aren't signed in, the extension prompts you to sign in once via the normal Trunk login flow; from then on it piggybacks on that session. | ||
| * **Session-based auth.** The extension reads your existing browser session at `app.trunk.io` on every PR page load. If you are signed out, the panel shows an inline **Sign in to Trunk** row instead of merge queue controls. Clicking through that row completes the normal Trunk login flow; once signed in the panel switches to the standard merge queue view automatically. |
Contributor
There was a problem hiding this comment.
Minor: missing comma after the introductory clause.
Suggested change
| * **Session-based auth.** The extension reads your existing browser session at `app.trunk.io` on every PR page load. If you are signed out, the panel shows an inline **Sign in to Trunk** row instead of merge queue controls. Clicking through that row completes the normal Trunk login flow; once signed in the panel switches to the standard merge queue view automatically. | |
| * **Session-based auth.** The extension reads your existing browser session at `app.trunk.io` on every PR page load. If you are signed out, the panel shows an inline **Sign in to Trunk** row instead of merge queue controls. Clicking through that row completes the normal Trunk login flow; once signed in, the panel switches to the standard merge queue view automatically. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
merge-queue/chrome-extension.mdto describe the inline Sign in to Trunk row that now appears in the extension panel when the Trunk session is signed outSource
Test plan
Generated by Claude Code