Skip to content

docs(flaky-tests): note automatic PR number detection on CircleCI#592

Merged
trunk-staging-io[bot] merged 2 commits intomainfrom
sam-gutentag/circleci-pr-number-detection
May 6, 2026
Merged

docs(flaky-tests): note automatic PR number detection on CircleCI#592
trunk-staging-io[bot] merged 2 commits intomainfrom
sam-gutentag/circleci-pr-number-detection

Conversation

@samgutentag
Copy link
Copy Markdown
Member

Summary

  • Documents that the Trunk Analytics CLI automatically detects the pull request number from CircleCI environment variables
  • No extra configuration is needed for PR-level test attribution on CircleCI

Source

Test plan

  • Preview in GitBook

Generated by Claude Code

The Trunk Analytics CLI detects PR context from CircleCI environment
variables automatically, including the pull request number (trunk2 PR #3781).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@trunk-staging-io
Copy link
Copy Markdown

trunk-staging-io Bot commented Apr 30, 2026

😎 Merged successfully - details.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Apr 30, 2026

Claude finished @samgutentag's task in 36s —— View job


Review

  • Gather context and read changed files
  • Review documentation changes

The change is a clean, well-placed addition. Here's my assessment:

What the PR does: Adds an info hint block to flaky-tests/get-started/ci-providers/circleci.md (lines 44–46) noting that the Trunk Analytics CLI auto-detects PR context from CircleCI environment variables, so no extra configuration is needed.

Placement: ✅ Correctly positioned right after the "Upload Test Results" step instructions — exactly where a user might wonder if additional PR configuration is needed.

Grammar & spelling: ✅ No errors found.

Formatting: ✅ Uses the GitBook {% hint style="info" %} syntax consistently with the rest of the file.

Minor observation (non-blocking): The phrase "detects PR context from CircleCI environment variables, including the pull request number" is slightly redundant — "PR context" already implies PR number. A tighter alternative could be:

The Trunk Analytics CLI automatically detects the pull request number from CircleCI environment variables. No additional configuration is needed to associate test uploads with the correct PR in Trunk.

But the current wording is perfectly readable and not incorrect, so this is just a style note.

Result: ✅ Approved — no blocking issues.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: Claude code review passed.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 5, 2026

Claude finished @samgutentag's task in 51s —— View job


Review

  • Gather context and read changed files
  • Review documentation changes

The change adds an {% hint style="info" %} block to flaky-tests/get-started/ci-providers/circleci.md noting that the Trunk Analytics CLI auto-detects PR context on CircleCI.

Placement: ✅ Well-positioned right after the "Upload to Trunk" intro — exactly where a user might wonder if extra PR configuration is needed.

Grammar & spelling: ✅ No errors.

Formatting: ✅ Uses {% hint style="info" %} syntax consistently with the rest of the file.

Minor style note (non-blocking): "PR context... including the pull request number" is slightly redundant — "PR context" already implies PR number. A tighter phrasing is suggested in the inline comment.

Result: ✅ No blocking issues.

Comment thread flaky-tests/get-started/ci-providers/circleci.md
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: Claude code review passed.

@samgutentag
Copy link
Copy Markdown
Member Author

Triage status (2026-05-05): up to date with main. Review approved. Ready to merge.

@samgutentag samgutentag marked this pull request as ready for review May 6, 2026 18:21
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 6, 2026

Claude finished @samgutentag's task in 48s —— View job


Review

  • Gather context and read changed files
  • Review documentation changes

The change adds an {% hint style="info" %} block to flaky-tests/get-started/ci-providers/circleci.md (lines 44–46) noting that the Trunk Analytics CLI auto-detects PR context — including the pull request number — from CircleCI environment variables.

Placement: ✅ Correctly positioned right after the "Upload to Trunk" step instructions — exactly where a user might wonder if extra PR configuration is needed, and before the existing danger hint about stable branches.

Grammar & spelling: ✅ No errors.

Formatting: ✅ Uses {% hint style="info" %} syntax consistent with the rest of the file. Blank lines around the block are correct.

Accuracy: ✅ Claim aligns with the linked trunk2 PR (#3781).

Minor style note (non-blocking): "PR context... including the pull request number" is slightly redundant — "PR context" already implies the PR number. A tighter alternative:

The Trunk Analytics CLI automatically detects the pull request number from CircleCI environment variables. No additional configuration is needed to associate test uploads with the correct PR in Trunk.

The current wording is perfectly readable, so this is just a style note.

Result: ✅ No blocking issues.
| Branch: sam-gutentag/circleci-pr-number-detection

@trunk-staging-io trunk-staging-io Bot merged commit 62a4b39 into main May 6, 2026
8 checks passed
@trunk-staging-io trunk-staging-io Bot deleted the sam-gutentag/circleci-pr-number-detection branch May 6, 2026 18:22
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: Claude code review passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants