Skip to content

docs(merge-queue): document Forced badge on force-merged PRs#571

Merged
trunk-staging-io[bot] merged 3 commits intomainfrom
sam-gutentag/merge-queue-forced-badge
May 6, 2026
Merged

docs(merge-queue): document Forced badge on force-merged PRs#571
trunk-staging-io[bot] merged 3 commits intomainfrom
sam-gutentag/merge-queue-forced-badge

Conversation

@samgutentag
Copy link
Copy Markdown
Member

Summary

  • Adds a callout in force-merge.md noting that force-merged PRs display a Forced badge in the Merge Queue dashboard PR list after merge.

Source

Test plan

  • Preview in GitBook

Generated by Claude Code

…oard list

Force-merged pull requests now show a Forced badge in the Merge Queue
dashboard PR list. Adds a one-line callout in the force-merge step-by-step
so users know how to identify bypass-protected merges at a glance.

Source: trunk2 PR #3708 (merged 2026-04-22)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@trunk-staging-io
Copy link
Copy Markdown

trunk-staging-io Bot commented Apr 23, 2026

😎 Merged successfully - details.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Apr 23, 2026

Claude finished @samgutentag's task in 1m 6s —— View job


PR Review

  • Gather context and read changed files
  • Check CLAUDE.md for repo guidelines
  • Review changes for typos, grammar, formatting, and documentation best practices
  • Post final feedback

The change is clean — one sentence, properly formatted with surrounding blank lines, no typos, and it adds useful visibility information for users.

One minor suggestion (non-blocking): The pronoun "it" on line 50 is slightly ambiguous. I've left an inline suggestion to make the subject explicit. Take it or leave it.

Formatting note: The PR description calls this a "callout" but the implementation is a plain paragraph rather than a {% hint %} block. That's fine — a {% hint style="info" %} would give it more visual weight, but a plain sentence reads naturally in context here.

Review: LGTM — no blocking issues.

Comment thread merge-queue/using-the-queue/force-merge.md Outdated
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: Claude code review passed.

Copy link
Copy Markdown
Contributor

@pv72895 pv72895 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 5, 2026

Claude finished @samgutentag's task in 41s —— View job


PR Review

  • Gather context and read changed files
  • Check CLAUDE.md for repo guidelines
  • Review changes for typos, grammar, formatting, and documentation best practices
  • Post final feedback

The change adds one sentence at line 50 of merge-queue/using-the-queue/force-merge.md:

After a PR is force-merged, it shows a Forced badge in the Merge Queue dashboard PR list so you can identify which merges bypassed branch protection.

Findings:

  • No typos or grammatical errors.
  • Forced is correctly bolded to match the UI label.
  • Blank lines surrounding the new paragraph are correct.
  • Placement between the step-by-step section and "Combining with other flags" is logical.

Minor (non-blocking): The pronoun "it" is slightly ambiguous — "it" refers back to "a PR" earlier in the sentence, which is clear enough in context, but making the subject explicit ("the PR") would be marginally cleaner. This was flagged in the previous review as a non-blocking inline suggestion and hasn't been addressed, but it's not blocking.

Review: LGTM — no blocking issues.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: Claude code review passed.

@samgutentag
Copy link
Copy Markdown
Member Author

Triage status (2026-05-05): up to date with main. Review approved and MERGEABLE. Ready to merge.

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 6, 2026

Claude finished @samgutentag's task in 44s —— View job


PR Review

  • Gather context and read changed files
  • Check CLAUDE.md for repo guidelines
  • Review changes for typos, grammar, formatting, and documentation best practices
  • Post final feedback

The latest commit (2f8b2d8) addresses the prior inline suggestion — "it" → "the PR" — making the subject explicit at line 50 of merge-queue/using-the-queue/force-merge.md:

After a PR is force-merged, the PR shows a Forced badge in the Merge Queue dashboard PR list so you can identify which merges bypassed branch protection.

Findings:

  • No typos or grammatical errors.
  • Forced is correctly bolded to match the UI label.
  • Surrounding blank lines are correct.
  • Placement between the step-by-step section and "Combining with other flags" is logical.
  • Prior ambiguity flagged in earlier reviews is now resolved.

Review: LGTM — no blocking issues.
| Branch

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: Claude code review passed.

@samgutentag samgutentag marked this pull request as ready for review May 6, 2026 17:53
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 6, 2026

Claude finished @samgutentag's task in 39s —— View job


PR Review

  • Gather context and read changed files
  • Check CLAUDE.md for repo guidelines
  • Review changes for typos, grammar, formatting, and documentation best practices
  • Post final feedback

The change adds a single sentence at line 50 of merge-queue/using-the-queue/force-merge.md:

After a PR is force-merged, the PR shows a Forced badge in the Merge Queue dashboard PR list so you can identify which merges bypassed branch protection.

Findings:

  • No typos or grammatical errors.
  • Forced is correctly bolded to match the UI label.
  • Surrounding blank lines are correct; placement between the step-by-step section and "Combining with other flags" is logical.
  • Latest commit (2f8b2d8) resolved the prior inline suggestion ("it" → "the PR"), removing the only minor ambiguity flagged in earlier reviews.
  • No CLAUDE.md present at the repo root, so no repo-specific guidelines to apply beyond standard docs conventions.

Review: LGTM — no blocking issues.
| Branch

@trunk-staging-io trunk-staging-io Bot merged commit 3039294 into main May 6, 2026
8 checks passed
@trunk-staging-io trunk-staging-io Bot deleted the sam-gutentag/merge-queue-forced-badge branch May 6, 2026 17:54
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: Claude code review passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants