Impl Local Sandbox - #306
Draft
chiragjn wants to merge 10 commits into
Draft
Conversation
🦋 Changeset detectedLatest commit: 116df00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chiragjn
force-pushed
the
local-sandbox-2
branch
from
August 17, 2026 17:48
e367620 to
0a82d16
Compare
Replace the pipe fixture with a product-shaped local client, inline it via build:gen, and point smoke at call-tool with TFY_MCP_SERVERS. Co-authored-by: Cursor <cursoragent@cursor.com>
… provider. Transports own script content and remotePath; Sandbox derives PYTHONPATH/PATH layout and skips install when Code Mode is unset. Co-authored-by: Cursor <cursoragent@cursor.com>
Documents standalone fallback, v1 sandbox ids, and copy-into-server sequencing before package removal. Co-authored-by: Cursor <cursoragent@cursor.com>
chiragjn
force-pushed
the
local-sandbox-2
branch
from
August 18, 2026 05:49
c663fad to
116df00
Compare
| getGitCredentialsPath(): string { | ||
| // Isolated container per sandbox; absolute path so GIT_CONFIG_* needs no $HOME expansion. | ||
| return '/tmp/.git-credentials'; | ||
| return join('/tmp', '.git-credentials'); |
| /** Current build status of the release image. Read-only: never kicks off a build. */ | ||
| getImageBuildStatus(): Promise<SandboxBuild>; | ||
| createSandbox(): Promise<{ sandboxId: string }>; | ||
| createSandbox(params?: { sessionId?: string }): Promise<{ sandboxId: string }>; |
Contributor
There was a problem hiding this comment.
app-home
db
*.sqlite
*.wal
*.checkpoint
sandboxes
session_dir <- provider contructor
ulid
want to standerdize the context input here a bit later.
| getToolResultDumpDir(sandboxId: string): string; | ||
| /** Absolute path for the git credential-store file (per logical sandbox when sharing a pod). */ | ||
| getGitCredentialsPath(sandboxId: string): string; | ||
| /** Directory for user-uploaded files (absolute, or cwd-relative when the provider has no global FS). */ |
Contributor
There was a problem hiding this comment.
Can we make it clear that we want abs path within the sandbox.
| instruction(builder: InstructionBuilder, paths: { skillsDir: string }): void; | ||
| // The command (+ env, timeout) that installs these skills; Sandbox folds it into its init exec. | ||
| getSandboxInit(): SandboxInit; | ||
| getSandboxInit(paths: { skillsDir: string; gitDownloaderPath: string }): SandboxInit; |
| return { pythonPath, binDir, binLink: join(binDir, 'mcp-client') }; | ||
| } | ||
|
|
||
| /** Fallback PATH tail when the provider does not pass PATH (Daytona image defaults). */ |
| function mcpClientLayout(remotePath: string): { pythonPath: string; binDir: string; binLink: string } { | ||
| const pythonPath = dirname(remotePath); | ||
| const binDir = join(pythonPath, 'bin'); | ||
| return { pythonPath, binDir, binLink: join(binDir, 'mcp-client') }; |
Contributor
There was a problem hiding this comment.
two sources of truth?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.