feat(ui): Agents Library row — connectors first, composer skill icon, hover names - #298
feat(ui): Agents Library row — connectors first, composer skill icon, hover names#298shubhamagarwal-create wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 174f640 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| const skillsCount = spec?.skills?.length ?? 0; | ||
| const mcpCount = spec?.mcpServers?.length ?? 0; | ||
| const skillNames = (spec?.skills ?? []).map(s => (s as { name?: string }).name).filter(Boolean); | ||
| const mcpNames = (spec?.mcpServers ?? []).map(m => (m as { name?: string }).name).filter(Boolean); |
There was a problem hiding this comment.
Unsafe mount name casts
Medium Severity
Connector and skill names are read via as { name?: string } on opaque runtime mounts. That silences typing instead of using a guard, and duplicates the existing draftMountsFromSpec helper the composer already uses for the same tooltip copy.
Triggered by project rule: TrueForge review rules
Reviewed by Cursor Bugbot for commit 2171c2d. Configure here.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 92b728f. Configure here.
| <Icon name="lightbulb" className="size-3.5" /> | ||
| {skillsCount} | ||
| </span> | ||
| </Tooltip> |
There was a problem hiding this comment.
Tooltip overflows on long names
Low Severity
Connector and skill tooltips join every name with no truncation, while the shared Tooltip defaults to whitespace-nowrap. Agents with many mounts can produce a single long line that runs off-screen, unlike the composer tooltip which truncates after four names and allows wrapping.
Reviewed by Cursor Bugbot for commit 92b728f. Configure here.
92b728f to
e7c2e34
Compare
… hover names - Order the row counts as Connectors (plug) then Skills, matching the composer. - Use the composer's `lightbulb` skill icon instead of `wrench` (which read as "tools"). - Show the actual connector/skill names on hover via the shared Tooltip primitive (renders above the Agents Library modal), replacing the plain title attribute. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The row now labels the counts with the connector/skill names ("Connectors: github",
"Skills: paint") instead of "N MCP servers" / "N skills".
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
e7c2e34 to
174f640
Compare
2 participants
Polish for the Agents Library rows so the icon set matches the composer and the counts aren't ambiguous.
Changes (
packages/trueforge-ui/src/atoms/AgentsLibrary.tsx)lightbulbicon instead ofwrench. The wrench read as "tools," which was confusing next to the connector count.Tooltipprimitive — the same component the composer uses. Replaces the plaintitleattribute so it's styled and consistent, and it renders above the Agents Library modal.Notes
CenteredModal(no z-index/portal issue).@truefoundry/trueforge-uipatch changeset included.🤖 Generated with Claude Code
Note
Low Risk
Presentation-only UI in Agents Library rows; no auth, data, or selection behavior changes.
Overview
Agents Library list rows now match the composer’s Connectors → Skills layout and iconography.
Connector counts (plug) appear before skill counts. Skills use the
lightbulbicon instead ofwrench. Hovering either count shows a sharedTooltipwith named lists (e.g. Connectors: github, Skills: paint) when names exist, with matchingaria-labeltext. Tests assert the new labels.Patch changeset for
@truefoundry/trueforge-ui.Reviewed by Cursor Bugbot for commit 174f640. Bugbot is set up for automated code reviews on this repo. Configure here.