Repository navigation
Conversation
…ntity This repo pinned an old ref that predates artifactory_oidc_provider_name, so it could not select a scoped identity and kept authenticating as the org-wide account -- which holds MANAGE across an entire artifact tier. Bumping to @main is interface-safe: no new required inputs and nothing removed between the pinned ref and main. Also drops artifactory_username/password, which are declared but ignored on main (auth is OIDC-only). Co-Authored-By: Claude Code <noreply@anthropic.com>
DeeAjayi
requested review from
chiragjn,
debajyoti-truefoundry and
nikp1172
as code owners
October 20, 2026 13:47
mitanshudodia
approved these changes
Oct 21, 2026
mitanshudodia
left a comment
There was a problem hiding this comment.
Approved — workflow-only diff verified (scoped JFrog OIDC via github-jfrog-private, deprecated username/password secrets dropped). Title updated to include INFRA-1994. Do NOT merge until truefoundry/ubermold-truefoundry#2314 (per-repo OIDC allowlist) is merged and applied, otherwise publishing will fail at push time.
DeeAjayi
enabled auto-merge (squash)
October 22, 2026 15:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repo pinned an old ref of the shared build workflow. That ref predates the
artifactory_oidc_provider_nameinput — and in fact predates OIDC entirely: it authenticated to JFrog with a static username and password viadocker/login-action, using org-wide credentials with no repository scoping at all.Bumping to
@mainmoves this repo onto the OIDC token exchange and lets it select a least-privilege identity.Changes
truefoundry/github-workflows-public/.github/workflows/build.ymlfrom@v0.1.5to@mainartifactory_oidc_provider_name: github-jfrog-publicartifactory_username/artifactory_password— declared but ignored onmain, auth is OIDC-onlyIs the bump safe?
Interface-checked: between
@v0.1.5andmainthere are no new required inputs, and no inputs or secrets removed. The shared workflow has only grown additively.Behaviour may still differ — this skips several releases — so watch the first run.
Depends on
ubermold-truefoundry#2314 adds the allowlist this repo needs. Merge that first. Until then this repo is not on the
github-jfrog-publicallowlist and the push fails authorization.After merging
Confirm the next build actually pushed. A wrong or missing allowlist entry fails at push time, not at plan time.
🤖 Generated with Claude Code
Note
Medium Risk
Changes how release images authenticate and publish to Artifactory; a misconfigured OIDC allowlist fails at push time and the
@mainworkflow pin may behave differently than@v0.1.5.Overview
Updates release-to-jfrog so JFrog pushes use the shared build workflow on
@maininstead of pinned@v0.1.5.Authentication switches from username/password secrets to OIDC via
artifactory_oidc_provider_name: github-jfrog-public, so the job can use a scoped JFrog identity rather than the org-wide Artifactory account. The workflow no longer passesartifactory_username/artifactory_passwordto the reusable job.Note: The first run after merge should be watched; authorization depends on the
github-jfrog-publicallowlist (see related infra PR).Reviewed by Cursor Bugbot for commit 5537cba. Bugbot is set up for automated code reviews on this repo. Configure here.