Repository navigation
Conversation
d91bf7c to
285cd29
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc2372f8d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| StringBuilder sb = new StringBuilder(); | ||
| sb.Append("class User {\n"); | ||
| sb.Append(" Id: ").Append(Id).Append("\n"); | ||
| sb.Append(" Firstname: ").Append(Firstname).Append("\n"); |
There was a problem hiding this comment.
When a User is logged in the C# SDK, this ToString() emits names, email, employee number, login, metadata, and other fields that are not approved by x-log; the generated Kotlin data-class toString() and Python to_str() have the same problem. This defeats the repository's explicit allow-list and can put personal data into application logs, so the non-Java generators need equivalent filtered string-generation templates.
AGENTS.md reference: AGENTS.md:L37-L39
Useful? React with 👍 / 👎.
| - name: Verify generated sources are committed | ||
| run: | | ||
| git diff --exit-code || ( |
There was a problem hiding this comment.
Plain git diff --exit-code ignores untracked files, so when a specification change generates a new API or model file without modifying an existing tracked file, this verification step succeeds even though that generated source was never committed. Check the porcelain status or otherwise include untracked output so CI enforces the documented no-drift invariant.
AGENTS.md reference: AGENTS.md:L56-L58
Useful? React with 👍 / 👎.
972402f to
2b32338
Compare
Three numbers move at different rates: the path version marks compatibility, the specification version names the published contract, and each SDK has a version of its own. VERSIONING.md states this for readers; docs/ records how the two repositories arrange it — the service leads on the contract including its version, this repository on publication — and what is still to build. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
A client library for Java, Kotlin, Python, TypeScript, Swift and C#, generated from the specification and committed, so each one stays in step with the contract and carries the version it was built from. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Seven versions in one file are seven chances to mistype one. The script bumps the whole set for a specification update and named clients for a fix of their own, resolves every name before it writes so a typo cannot half apply a bump, and leaves the comments and order of the file alone. A major bump stays a hand edit: it says a client breaks its callers, which is not a thing to reach for by passing a different word to a script.
80aef86 to
6ccc76e
Compare
Stacked on #1 — review that one first.
The client SDKs generated from
spec/openapi.yaml, so an integrator does not have to generate them to start: Java, Kotlin, TypeScript (fetch), Python, C# and Swift.How they are produced
Generation is driven from the specification by OpenAPI Generator, with an overlay of its own (
sdk/overlay.yaml) for what the generators need but the contract should not state. The generated sources are committed rather than built on demand, so a reader can see exactly what a client looks like, and a regeneration shows up as a reviewable diff instead of a silent change.Publishing is not wired up yet
Deliberately. The artifact names are not settled, so nothing here publishes on its own:
sdk.ymlbuilds and verifies the SDKs on pull requests and onmain.publish-snapshot.ymlandrelease.ymlareworkflow_dispatchonly — they never fire from a push or a merge.The registry addresses are repository variables rather than literals in the workflows, so nothing in this repository names an internal host. Those variables and the
Snapshot/Releaseenvironments still have to be created before either workflow can run.Open before the first publish
🤖 Generated with Claude Code