Repository navigation
Conversation
…i into tm/macos-support
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 25 25
Lines 1260 1260
Branches 74 74
=======================================
Hits 1211 1211
Misses 45 45
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Closed
benegee
marked this pull request as ready for review
September 24, 2026 09:58
sloede
reviewed
Sep 24, 2026
Comment on lines
+74
to
+76
| if: >- | ||
| github.event_name != 'pull_request' || | ||
| github.event.pull_request.head.repo.full_name == github.repository |
Member
There was a problem hiding this comment.
Suggested change
| if: >- | |
| github.event_name != 'pull_request' || | |
| github.event.pull_request.head.repo.full_name == github.repository | |
| # Only deploy on merge to `main` | |
| if: >- | |
| github.event_name != 'pull_request' || | |
| github.event.pull_request.head.repo.full_name == github.repository |
For clarity?
| printf ("\n*** T8code *** Local number of elements:\t%i\n", local_num_elements); | ||
| printf ("*** T8code *** Global number of elements:\t%li\n", global_num_elements); | ||
|
|
||
| // Using PRId64 to print t8_gloidx_t portably across platforms |
Member
There was a problem hiding this comment.
This comment would be more helpful if it included what PRId64 is and where it comes from, e.g., something like
Suggested change
| // Using PRId64 to print t8_gloidx_t portably across platforms | |
| // Using special integer type PRId64 (defined in t8code.h) to print t8_gloidx_t portably across platforms |
Merged
Collaborator
Author
|
Implemented in #318 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revised version of #298