feat: Add config-manager push variables - #71
Conversation
0cd3706 to
23639d6
Compare
|
@dallinjsevy, I'm trying to focus on config-manager PRs Preston hasn't commented on yet: was this one eventually going to be brought out of draft? Can I help on this PR and/or proceed with a review after moving it out of draft? |
|
Note: PR is on hold. fr-config manager handles variables and secrets a little different; Preston and team to make some decisions. |
23639d6 to
a01c783
Compare
a01c783 to
d8e66aa
Compare
c72fe6b to
0c0827a
Compare
phalestrivir
left a comment
phalestrivir
left a comment
There was a problem hiding this comment.
Make sure to clean up the unused mocks when you are done getting tests passing. There are a bunch that need to be deleted, and with the flag changes I suggested in the comments below you will likely have more that need to be deleted since you will need to re-record.
|
Another thing, we will want to add the |
c47732d to
d7f350f
Compare
| { | ||
| "_id": "esv-connector-timeout-reset-counter", | ||
| "description": "", | ||
| "expressionType": "string", |
There was a problem hiding this comment.
Yes, you need to delete it from AIC first, and then re-import it as an int, since you can't change an existing ESV's type. I would like it to be int since we already have a string type ESV, so I want to make sure something like an int would import as well. You may also want to create another ESV for testing that is an object type since that one would be interesting to test as well, although it's probably not necessary, as long as we have at least two. They are technically all stored as strings in AIC, but the difference comes when they get used in scripts in AIC, but I just want to make sure that something that isn't a string type will still be imported correctly.
0e4c91f to
d3679fb
Compare
phalestrivir
left a comment
phalestrivir
left a comment
There was a problem hiding this comment.
Make sure all the tests are passing, since there are some test updates that are missing from the PR still.
phalestrivir
left a comment
phalestrivir
left a comment
There was a problem hiding this comment.
Squash your commits before submitting the PR against Rockcarver, and don't forget to undraft this PR: rockcarver/frodo-lib#625
77fb78a to
d15e7b2
Compare
|
Created PR against Rockcarver |
3 participants
No description provided.