feat: Add config-manager push secrets - #70
Open
dallinjsevy wants to merge 10 commits into
Open
Conversation
dallinjsevy
force-pushed
the
feature-config-manager-push-secrets
branch
5 times, most recently
from
March 25, 2026 21:54
acb1967 to
f169ae5
Compare
phalestrivir
force-pushed
the
feature-config-manager-push-secrets
branch
from
March 30, 2026 17:50
f169ae5 to
e01e9f4
Compare
phalestrivir
requested changes
Mar 30, 2026
phalestrivir
left a comment
phalestrivir
left a comment
There was a problem hiding this comment.
See my comments below for the requested changes
| ); | ||
|
|
||
| program | ||
| .description('Import ESV secrets.') |
There was a problem hiding this comment.
We are missing some flags:
-n, --name
-x, --prune
There was a problem hiding this comment.
Don't use client ESVs, delete this and instead use your own test secrets.
There was a problem hiding this comment.
Don't use client ESVs, delete this and instead use your own test secrets.
There was a problem hiding this comment.
Don't use client ESVs, delete this and instead use your own test secrets.
There was a problem hiding this comment.
Don't use client ESVs, delete this and instead use your own test secrets.
There was a problem hiding this comment.
Don't use client ESVs, delete this and instead use your own test secrets.
|
|
||
| /* | ||
| // ForgeOps | ||
| FRODO_MOCK=record FRODO_NO_CACHE=1 FRODO_HOST=https://nightly.gcp.forgeops.com/am frodo config-manager push secrets -D test/e2e/exports/fr-config-manager/forgeops -m cloud |
There was a problem hiding this comment.
This is not a ForgeOps test, but a cloud test, so make sure this comment reflects that. Also, we don't need to include the -m flag for cloud deployments (although it's fine to leave it in if you want to)
| const importData = JSON.parse(readFile); | ||
| const singleSecretImport: SecretsExportInterface = { | ||
| secret: { [importData._id]: importData }, | ||
| }; |
There was a problem hiding this comment.
In addition to supporting the flags I mentioned previously, we'll need to have support like we are doing for ESV variables to provide ENV that sets the variables before attempting to import them.
dallinjsevy
marked this pull request as draft
March 31, 2026 21:13
dallinjsevy
force-pushed
the
feature-config-manager-push-secrets
branch
from
June 10, 2026 16:34
e01e9f4 to
086d9ef
Compare
dallinjsevy
marked this pull request as ready for review
June 16, 2026 16:47
phalestrivir
requested changes
Aug 12, 2026
dallinjsevy
force-pushed
the
feature-config-manager-push-secrets
branch
from
August 17, 2026 17:24
681d71b to
eca7a8b
Compare
dallinjsevy
force-pushed
the
feature-config-manager-push-secrets
branch
from
August 20, 2026 15:18
eca7a8b to
cfcc29f
Compare
phalestrivir
requested changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.