feat: add config-manager push test - #124
Conversation
There was a problem hiding this comment.
I had the idea to go ahead and merge the test commands into "one" command to avoid doing the same thing multiple times. Since we don't have a frodo command that does this either, I created one, and the config-manager test commands use it.
This will be nice I think since config-manager does a similar thing, and we might as well have a frodo command that does it as well.
Note that we want the commands to work for any deployment, and also that I simplified the command, so I made those changes as part when creating the conn test command.
There are still some tests that need to be created for these commands, so see my comments below.
There was a problem hiding this comment.
We'll need a test like this for frodo conn test as well
There was a problem hiding this comment.
I'm thinking we should have a test for testFail as well where we attempt connecting using invalid credentials. That would look something like this:
test('"frodo config-manager push test": should fail connection with invalid credentials"', async () => {
const CMD = `frodo config-manager push test ${c.host} ${c.realm} username password`;
await testFail(CMD, env);
});The other thing is we'll want the tests for config-manager-pull-test and conn-test to match these tests exactly, with the only difference being the command being run.
| const output = await exec(CMD, env); | ||
| expect(output.stdout).toMatchSnapshot(); | ||
| expect(output.stderr).toMatchSnapshot(); |
There was a problem hiding this comment.
Use await testSuccess(CMD, env); here
No description provided.