Feature/config manager push telemetry by dallinjsevy · Pull Request #122 · trivir/frodo-cli

dallinjsevy · 2026-07-22T14:33:21Z

No description provided.

phalestrivir

You may want to wait until the ESV variables PR is in that adds the global flags you need to make the changes for this PR (since you will need them)

phalestrivir · 2026-08-10T19:06:33Z

+/*
+FRODO_MOCK=record FRODO_NO_CACHE=1 FRODO_HOST=https://openam-frodo-dev.forgeblocks.com/am frodo config-manager push telemetry -c otlp -N datadog -e test-value -D test/e2e/exports/fr-config-manager/cloud
+FRODO_MOCK=record FRODO_NO_CACHE=1 FRODO_HOST=https://openam-frodo-dev.forgeblocks.com/am frodo config-manager push telemetry -D test/e2e/exports/fr-config-manager/cloud
+*/


Add another test for importing using only the -c flag (no -n flag), and have it import the splunk configuration that you add in so we can also test importing splunk.

phalestrivir · 2026-08-20T16:35:27Z

+const { CLOUD_DEPLOYMENT_TYPE_KEY, FORGEOPS_DEPLOYMENT_TYPE_KEY } =
+  frodo.utils.constants;
+
+const deploymentTypes = [
+  CLOUD_DEPLOYMENT_TYPE_KEY,
+  FORGEOPS_DEPLOYMENT_TYPE_KEY,
+];


Remove Forgeops deployment type

phalestrivir · 2026-08-20T16:37:02Z

+  return false;
+}
+
+export async function configManagerImportTelemetry(


Missing function comment

phalestrivir · 2026-08-20T16:38:41Z

+        command
+      );
+
+      const getTokensIsSuccessful = await getTokens(


Missing check before this. Need to ensure category is provided if name is also provided:

if (options.name && !options.category) { printMessage( 'Named telemetry config requires category (e.g. --category otlp)', 'error' ); process.exitCode = 1; program.help(); }

phalestrivir · 2026-08-20T16:48:46Z

+    const importData: TelemetryExportInterface = {
+      telemetry: Object.fromEntries(
+        categories.map((cat) => [cat, []])
+      ) as TelemetryExportInterface['telemetry'],
+    };


I would change this to:

const importData = { telemetry: Object.fromEntries( categories.map((cat) => [cat, []]) ), } as TelemetryExportInterface;

I think that will fix the type issues while being a big more readable.

phalestrivir · 2026-08-20T16:48:57Z

+        .filter((f) => !name || f === `${name}.json`);
+      for (const file of files) {
+        const filePath = `${catDir}/${file}`;
+        const provider = readJsonFile(filePath) as any;


I would change any to LogExporterSkeleton

phalestrivir · 2026-08-20T17:00:56Z

I would delete this one. I think we should only have one otlp test file

phalestrivir · 2026-08-20T17:01:47Z

+ */
+
+/*
+FRODO_MOCK=record FRODO_NO_CACHE=1 FRODO_HOST=https://openam-frodo-dev.forgeblocks.com/am frodo config-manager push telemetry -n test-otlp -E TELEMETRY_HEADER_OTLP_TEST_OTLP_API_KEY=test-value -E TELEMETRY_HEADER_OTLP_TEST_OTLP_API_SECRET=test-value -D test/e2e/exports/fr-config-manager/cloud 


This one needs -n to become -c, since -n by itself shouldn't work

phalestrivir · 2026-08-20T17:02:15Z

+
+/*
+FRODO_MOCK=record FRODO_NO_CACHE=1 FRODO_HOST=https://openam-frodo-dev.forgeblocks.com/am frodo config-manager push telemetry -n test-otlp -E TELEMETRY_HEADER_OTLP_TEST_OTLP_API_KEY=test-value -E TELEMETRY_HEADER_OTLP_TEST_OTLP_API_SECRET=test-value -D test/e2e/exports/fr-config-manager/cloud 
+FRODO_MOCK=record FRODO_NO_CACHE=1 FRODO_HOST=https://openam-frodo-dev.forgeblocks.com/am frodo config-manager push telemetry -c otlp -n datadog -E TELEMETRY_HEADER_OTLP_DATADOG_DD_API_KEY=test-value -D test/e2e/exports/fr-config-manager/cloud


Change -n datadog to -n test-otlp since we are going to get rid of the datadog one

phalestrivir · 2026-08-20T17:03:07Z

+FRODO_MOCK=record FRODO_NO_CACHE=1 FRODO_HOST=https://openam-frodo-dev.forgeblocks.com/am frodo config-manager push telemetry -c otlp -n datadog -E TELEMETRY_HEADER_OTLP_DATADOG_DD_API_KEY=test-value -D test/e2e/exports/fr-config-manager/cloud
+FRODO_MOCK=record FRODO_NO_CACHE=1 FRODO_HOST=https://openam-frodo-dev.forgeblocks.com/am frodo config-manager push telemetry -c splunk -n test -D test/e2e/exports/fr-config-manager/cloud
+FRODO_MOCK=record FRODO_NO_CACHE=1 FRODO_HOST=https://openam-frodo-dev.forgeblocks.com/am frodo config-manager push telemetry -c splunk -D test/e2e/exports/fr-config-manager/cloud
+*/


We should add one more test where you import everything with just -D. This is the only test we should expect to have fail (because it will be importing multiple exporters which isn't allowed), all other tests should succeed

phalestrivir · 2026-08-20T17:03:37Z

+describe('frodo config-manager push telemetry', () => {
+  test(`"frodo config-manager push telemetry -n test-otlp -E TELEMETRY_HEADER_OTLP_TEST_OTLP_API_KEY=test-value -E TELEMETRY_HEADER_OTLP_TEST_OTLP_API_SECRET=test-value -D ${telemetryDir}": should push telemetry to cloud`, async () => {
+    const CMD = `frodo config-manager push telemetry -n test-otlp -E TELEMETRY_HEADER_OTLP_TEST_OTLP_API_KEY=test-value -E TELEMETRY_HEADER_OTLP_TEST_OTLP_API_SECRET=test-value  -D ${telemetryDir}`;
+    await testSuccess(CMD, env);
+  });
+
+  test(`"frodo config-manager push telemetry -c otlp -n datadog -E TELEMETRY_HEADER_OTLP_DATADOG_DD_API_KEY=test-value -D ${telemetryDir}": should fail to import otlp telemetry`, async () => {
+    const CMD = `frodo config-manager push telemetry -c otlp -n datadog -E TELEMETRY_HEADER_OTLP_DATADOG_DD_API_KEY=test-value -D ${telemetryDir}`;
+    await testFail(CMD, env);
+  });
+
+  test(`"frodo config-manager push telemetry -c splunk -n test -D ${telemetryDir}": should fail to import splunk telemetry`, async () => {
+    const CMD = `frodo config-manager push telemetry -c splunk -n test -D ${telemetryDir}`;
+    await testFail(CMD, env);
+  });
+
+  test(`"frodo config-manager push telemetry -c splunk -D ${telemetryDir}": should fail to import splunk telemetry`, async () => {
+  const CMD = `frodo config-manager push telemetry -c splunk -D ${telemetryDir}`;
+  await testSuccess(CMD, env);
+});


Make sure to update the test descriptions accordingly after you make the changes I suggested.

phalestrivir · 2026-08-20T17:20:15Z

Also, ensure that the config import and config export tests are passing, since I updated the library to include telemetry in the full export/import. You don't need to re-record those tests, you can just add the network calls to the mock recordings that are missing (the ones for telemetry) and then they should pass again (although you may need to still run update to update the snapshots). You can find those mock requests from the mock recordings for your config-manager push/pull test mocks. Let me know if you have questions on how to do this, but we don't want to re-record those because we don't want to break anything in the tenant

dallinjsevy requested a review from phalestrivir July 22, 2026 14:33

phalestrivir requested changes Aug 10, 2026

View reviewed changes

dallinjsevy added 6 commits August 19, 2026 10:44

feat: add config-manager-pull telemetry command

2cca624

wip

e5ff552

fixup! update config-manager pull telemetry

acbb1d8

wip

e3c8afb

feat: add config-manager push telemetry command

78e8635

fixup! resolve PR comments. update test name.

2c24ca1

dallinjsevy force-pushed the feature/config-manager-push-telemetry branch from 927a373 to 2c24ca1 Compare August 19, 2026 21:50

phalestrivir requested changes Aug 20, 2026

View reviewed changes

Uh oh!

Conversation

dallinjsevy commented Jul 22, 2026

Uh oh!

phalestrivir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

phalestrivir commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

phalestrivir commented Aug 20, 2026 •

edited

Loading