feat: add config-manager-pull telemetry command - #121
Conversation
There was a problem hiding this comment.
Please update the other tests that are affected by the new changes I added to the library as well. Since the full export/import include telemetry now, we need to update config-export and config-import tests, and also update usage tests that do a full export (namely script-list, script-describe, esv-variable-list, esv-variable-describe, esv-secret-list, esv-secret-describe).
Note that there is a trick you can do so you don't have to re-record all the export/import tests. You only need to add the request that's missing to the mocks to get them passing. If you need help doing this let me know and I can show you how I usually do it.
cd93d1a to
9ff7788
Compare
|
|
||
| /* | ||
| FRODO_MOCK=record FRODO_NO_CACHE=1 FRODO_HOST=https://openam-frodo-dev.forgeblocks.com/am frodo config-manager pull telemetry -D telemetryTestDir | ||
| FRODO_MOCK=record FRODO_NO_CACHE=1 FRODO_HOST=https://openam-frodo-dev.forgeblocks.com/am frodo config-manager pull telemetry -c otlp -D telemetryTestDir2 |
There was a problem hiding this comment.
Could we update this test to be the splunk category so that way we have a test for that? You shouldn't need to re-record the mocks for it, since the filtering happens after the API calls are made, but you will need to update the snapshots after the change.
There was a problem hiding this comment.
I tried modify the test to use splunk but I think the Frodo tenant only has otlp as telemetry config. Since Ping only allows a single category to be configured, I think I would need to test against a different tenant to export splunk config.
There was a problem hiding this comment.
Delete this file (only used for the push command, so you can add it in that PR)
|
Also, reference this comment to update the tests for config export/import (need to do that as part of this PR): #121 (review) |
9ff7788 to
acbb1d8
Compare
|
I kept the incorrectly named file FrConfigTelemetry so you are able to see the diff. I also included the correctly named file. I will delete the file once the changes have been reviewed. |
2 participants
No description provided.