refactor: realm flag removal for config-manager - #116
Conversation
phalestrivir
left a comment
There was a problem hiding this comment.
After the changes, make sure to update the tests accordingly. Main thing to remember is that for those commands that due use the realm argument we need to have a separate test where we specify the realm that way, which it looks like you already did, but I won't look over the tests until these changes are done since the tests I know are going to change for a lot of these. For example, all-static has the realm test that you added which is good, but we never did implement the realm argument for it (which I left a comment about), so once you implement that you will need to re-record that test since it currently doesn't test anything.
a955322 to
5fdd5c2
Compare
6cd062d to
5f23d6f
Compare
eb98657 to
2c89667
Compare
|
I've made the changes I think are good for review for now. The all-static is not complete, I need to know what functions apply to that one. I can record tests properly once I know that. |
I added some notes to this clickup article on which configurations are static: https://app.clickup.com/45049292/v/dc/1aytec-23271/1aytec-64011 |
Removal of
-r, --realmflag throughout config-manager pull commands as there was a redundancy created as Frodo already has the realm argument built in.