Repository navigation
ui: @trick77/diagram 0.1.8 - #401
Merged
Merged
Conversation
The mermaid fallback now refuses a source that could make the browser fetch on render and shows it as code. The card says why a diagram was not drawn, so a refusal reads apart from a parse error. A stored JSON spec has no size cap and may reach the renderer: its labels are written for drawing with URLs, slashes and backslashes broken up, so one such label no longer costs the picture; the clipboard keeps them as written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes @trick77/diagram 0.1.8. The mermaid fallback refuses a source that could make the browser fetch on render (an image in node data, a url() in a style, HTML that loads), re-checks the rendered SVG and locks its config; a directive's config is dropped as inert. A refused fence shows as the existing "Diagram could not be drawn" details, now with the package's reason above the source, so a refusal reads apart from a parse error.
A stored JSON spec has no size cap and may reach the renderer: its labels are written for drawing with URLs, slashes and backslashes broken up (toDrawing), so one such label no longer costs the picture; the clipboard keeps them as written. New tests run the real draw: code words like ResolveURL( and generics draw, a loading style is refused with its reason.