Repository navigation
ui: draw diagrams with trick77/diagram - #399
Merged
Merged
Conversation
trick77
marked this pull request as draft
November 22, 2026 14:26
trick77
force-pushed
the
diagram-pkg
branch
3 times, most recently
from
November 22, 2026 16:23
eb3c77b to
c2736ae
Compare
trick77
marked this pull request as ready for review
November 22, 2026 16:23
Layout, drawing, mermaid adapter, card and full view come from @trick77/diagram 0.1.3 instead of rongo's copy (about 7.9k lines out). rongo keeps the legacy JSON fence, the clipboard rewrite, the pending and error states, PlantUML and its overlay shell. Corpus cards and downloads are unchanged; the full view sizes to the drawing. The answer prompt asks for lanes where work passes between roles and a class diagram for how types are built. Measured on a fixed context, MiMo flash, two runs per arm: class 4 of 4 (base 0 of 4), lanes 2 of 4 (base 0 of 4, the misses valid flowchart and sequence), rubric 37/38 against 35/38, the control stays an entity diagram (docs/measurements/2026-11-22-lanes-and-classes.md). The harness tallies lanes apart from flowcharts (ask.DiagramShape) and reads a fence's kind past front matter, as the browser does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diagrams are drawn by the shared package @trick77/diagram 0.1.3 instead of rongo's own copy of the layout, drawing, mermaid adapter, card and full view (about 7.9k lines removed). rongo keeps the legacy JSON fence, the clipboard rewrite, the pending and error states, PlantUML and its overlay shell. Every corpus card and download is unchanged; the full view now sizes to the drawing.
The answer prompt asks for two shapes the package adds: lanes where work passes between roles, and class diagrams for how types are built. Measured on a fixed context, MiMo flash, two runs per arm: class questions drew a class diagram 4 of 4 (base 0 of 4), lane questions drew lanes 2 of 4 (base 0 of 4; the misses are a valid flowchart and sequence), rubric 37/38 against 35/38, the control question stays an entity diagram. Details in docs/measurements/2026-11-22-lanes-and-classes.md.