Skip to content

transfer: propagate shared file failures to dependent directories - #677

Open
AryanRG wants to merge 1 commit into
treeverse:mainfrom
AryanRG:fix/shared-file-transfer-failures
Open

AryanRG wants to merge 1 commit into
treeverse:mainfrom
AryanRG:fix/shared-file-transfer-failures

Conversation

@AryanRG

@AryanRG AryanRG commented Oct 25, 2026 •

Copy link
Copy Markdown

A failed copy of a file shared by multiple directories currently blocks only the first directory. Later directory manifests can still be written and reported as transferred even though their contents are missing.

Keep earlier file failures when deciding whether to transfer each directory. The regression covers shared-file failures, healthy transfers, unrelated progress and a successful retry.

Validated with the full local test suite, project hooks, mypy and package build checks, with Click installed locally. Hosted lint hits the existing Click dependency issue (#671); the benchmark failure occurs on the unchanged base.

@github-project-automation github-project-automation Bot moved this to Backlog in DVC Oct 25, 2026
@CLAassistant

CLAassistant commented Oct 25, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov

codecov Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.24%. Comparing base (e38c8c2) to head (9a3e5bf).
⚠️ Report is 72 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
+ Coverage   72.42%   74.24%   +1.81%     
==========================================
  Files          67       66       -1     
  Lines        5132     5396     +264     
  Branches      605      625      +20     
==========================================
+ Hits         3717     4006     +289     
+ Misses       1227     1195      -32     
- Partials      188      195       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants