Repository navigation
Bind work-item question gates and expose safe native MCP failures - #623
Merged
Merged
Conversation
adrianwebb
force-pushed
the
codex/work-item-question-gates553
branch
from
October 25, 2026 02:20
23d2c29 to
bb66a4b
Compare
adrianwebb
marked this pull request as ready for review
October 25, 2026 05:26
7 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Blocking inbox questions now gate only their related proposal work items. Managed answers require exact immutable read-back; a reopen or changed source invalidates the proof, and agent replies remain evidence for managed evaluation. Native MCP exposes safe typed Problem responses so coordinators can diagnose the same backend failures seen over REST.
Work authority
Contributor mode (select one):
Plan
Completed the shared authoring/gateway repairs, question-to-graph connection, exact answer provenance and serialized lifecycle transitions. Reused the existing graph-readiness observation for typed graph_not_ready and the existing REST Problem formatter for MCP. No new runner, status store, schema, migration or agent-specific proposal targeting.
Changes and commits
Authoring permissions retain governed schema/source authority. Question proof writes lock the inbox row and condition the state transition on the exact source and lifecycle sequence. Advisory, foreign and unknown relationships attach no work-item gate. Existing ownership and review behavior remain unchanged.
The graph query observes exact dependency readiness only after the typed not-ready response and re-queries the same authority. MCP catches typed ControlPlaneOperationError only, returning safe code/status/detail/requestId/instance as structuredContent and JSON text with isError=true. Causes and credentials are excluded; resources and signed confirmation receipts retain their existing behavior.
Verification
Exact-head Actions40159462985 passed complete owner verification, native TreeDX prerequisites, PostgreSQL backup/identity/concurrent-allocation checks, artifact packing, coded component scenes and cleanup. Local combined focused verification passed99cases/15files, strict build and policies.
Real native MCP on the qualified85eff candidate returned409/discussion_agent_chat_profile_missing for the retained group request, confirming structured diagnosis. Source inspection identifies a separate group-alias admission bug now tracked through real API proposal8bc60c93. The Deployment question was observed gating only Releaser while Writer was admitted. Full portfolio simulated release remains unproven; failed review/Reporter observations are retained in docs/agent-log.md.
Risk and rollback
No migration. Blocking questions require managed approval; a normal comment cannot release their authority. Roll back through the existing exact-ref delivery process to c7e9bab, preserving all Git/TreeDX products, history and accounting. Group-alias admission, interrupted finalization and full simulation parity are separate unresolved work.
Completion summary
Exact candidate verification passed and supported coached adoption succeeded; final protected staging integration follows the checked PR. This is shared-backend bootstrap delivery, not a claim of a complete native-MCP simulated release.
AGPL committer authorization
Existing base-owned authorization remains authoritative. No license or grant change.
Submission checklist