Repository navigation
Add OpenTelemetry support to AWS binary - #985
Closed
ryanmilne-digicert wants to merge 1 commit into
Closed
ryanmilne-digicert wants to merge 1 commit into
ryanmilne-digicert wants to merge 1 commit into
Conversation
ryanmilne-digicert
requested review from
mhutchinson
and removed request for
a team
November 6, 2026 20:38
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
Meant to create pull request in fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds comprehensive OpenTelemetry (OTel) metrics and tracing support to the AWS binary, closely aligning it with the POSIX binary's observability features. It introduces a new initialization routine for OTel, exposes configuration options via environment variables and flags, and includes robust documentation and tests for various exporter scenarios.
Key changes include:
OpenTelemetry Integration:
initOTelfunction inotel.goto set up OTel metrics, tracing, and Go runtime metrics using environment-driven exporters (OTLP, Prometheus, or none). This function configures resource attributes, sets up batchers, and ensures proper shutdown on service termination. (cmd/tesseract/aws/otel.go)--trace_fractionflag to control the sampling rate of root traces, with special handling for periodic Tessera root spans. (cmd/tesseract/aws/main.go)Configuration and Documentation:
cmd/tesseract/aws/README.md)Code Integration:
cmd/tesseract/aws/main.go)Testing:
cmd/tesseract/aws/otel_test.go)