Repository navigation
ci, test: make CI more reliable and more readable on failure - #1275
Merged
Merged
Conversation
Running go test with -v across ./... streams logs from all passing packages (over 50k lines), burying actual test failures. Without -v, go test buffers output per package and prints full logs only for packages that fail.
mhutchinson
force-pushed
the
fix/ci-quiet-test
branch
from
November 6, 2026 15:23
6813c2a to
54e66e7
Compare
phbnf
approved these changes
Nov 6, 2026
Contributor
Author
|
@phbnf tests are failing more than I'd like. I'm going to see if I can squeeze a minimal test-only change into this PR to unblock CI. |
Cancel the appender context on test log shutdown and before final fsck in POSIX GC tests, and drop the unnecessary 100ms checkpoint republish interval in TestGateway so background checkpoint/GC tickers do not race with t.TempDir() os.RemoveAll cleanup.
mhutchinson
changed the title
phbnf
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes CI test runs less flaky and much easier to read when a test does fail:
.github/workflows/go_test.yml): Drop-vfromgo testinvocations so Go buffers output per package and only prints full test logs for packages that fail (rather than streaming 50k+ lines of logs from passing packages).t.TempDir()cleanup in POSIX tests (testonly,storage/posix,internal/mirror/gateway): Cancel the POSIX appender context whentestonly.NewTestLogshuts down and before running finalfsck.CheckinTestGarbageCollect*, and remove the unnecessary 100ms checkpoint republish interval inTestGatewayso background checkpoint/GC tickers don't create files in.state/concurrently witht.TempDir()os.RemoveAllcleanup.