Repository navigation
🪪 [1/3] feat(sdk): add preference upload building blocks - #700
Open
michaelfarrell76 wants to merge 1 commit into
Open
michaelfarrell76 wants to merge 1 commit into
michaelfarrell76 wants to merge 1 commit into
Conversation
Move batchUploader and loadReferenceData into a new SDK preference-upload module, add buildPendingUpdates, the PreferenceUploadProgress type, and the NONE_PREFERENCE_MAP sentinel. Delete the unused CLI copies. Split out of #11.
@transcend-io/airgap.js-types
@transcend-io/cli
@transcend-io/custom-function-types
@transcend-io/design-tokens
@transcend-io/internationalization
@transcend-io/privacy-types
@transcend-io/sdk
@transcend-io/secret-value
@transcend-io/type-utils
@transcend-io/utils
commit: |
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Multi identifier preference uploads have been stuck in one giant stale PR, breaking it down so we can actually merge, test, and ship it as a major.
Stack (replaces #11)
main←michaelfarrell76/pref-upload-sdk-building-blocksmichaelfarrell76/pref-upload-sdk-building-blocks←michaelfarrell76/pref-upload-cli-statemichaelfarrell76/pref-upload-cli-state←michaelfarrell76/multi-identifier-preference-uploadsMerge in order: this PR → #701 → #702. Steps 1 and 2 are non-breaking. Step 3 carries the CLI and SDK majors.
Summary
preference-uploadmodule withuploadChunkWithSplit(moved from the CLI),loadReferenceData(moved frompreference-management), and the newbuildPendingUpdates.PreferenceUploadProgresstype andNONE_PREFERENCE_MAPsentinel.upload-preferences/upload/copies. Root@transcend-io/sdkexport names are unchanged.UploadProgressSinkmodule and thestatusfield onREQUEST_DATA_SILOS.Test plan
pnpm -F @transcend-io/sdk typecheckpnpm -F @transcend-io/sdk exec vitest run src/preference-upload(newbuildPendingUpdatestest, movedbatchUploaderandloadReferenceDatatests)pnpm -F @transcend-io/cli typecheckand the CLI codebase + upload-preferences testsquality:fixand pre-push hooks