Repository navigation
feat(billing): Add plan management to settings - #15
Merged
Merged
Conversation
Code Review SummaryThe standalone billing page is replaced by a Plan and billing tab rendered by a new settings component, with /billing redirecting into it while preserving query parameters so checkout and portal returns still land. The tab adds plan status chips, a percentage usage meter, plan-derived region options, dynamic trial copy, and dismissable checkout notices. Backend integration metadata now contributes a settings tab instead of a sidebar entry. 🚀 Key Improvements
💡 Minor Suggestions
|
| status.value = current.data; | ||
| pricing.value = plans.data; | ||
| region.value = defaultRegion(plans.data, region.value); | ||
| } catch (e) { |
There was a problem hiding this comment.
loadError is only rendered when status is null, so a failed refresh (the notice's Refresh status button) sets loadError but shows the user nothing while stale data stays on screen. Surface it through the existing error notice when data is already loaded.
Suggested change
| } catch (e) { | |
| } catch (e) { | |
| loadError.value = extractApiErrors(e); | |
| if (status.value) actionError.value = loadError.value; | |
| } finally { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move plan management into Settings while preserving checkout and portal returns.