[pull] master from golang:master - #200
Merged
Merged
Conversation
Forgot to add SizeAndAlign support to the ssa check mode in CL 824984. Fixes #65827 Change-Id: I8582e43bd7b2521aac0d2fa51db9ce54333bd08c Reviewed-on: https://go-review.googlesource.com/c/go/+/827324 LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Keith Randall <khr@golang.org> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Joel Sing <joel@sing.id.au>
The arm64 callerSave set omitted the sixteen P registers, so the register allocator believed calls preserve them and could keep a live mask in a P register across a call that clobbers it. amd64 includes its K mask registers in callerSave; do the same for pred. For #79781. Change-Id: I5c64e751f0d10a66615208beff9f13858cd0730a Reviewed-on: https://go-review.googlesource.com/c/go/+/827485 Reviewed-by: Junyang Shao <shaojunyang@google.com> Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Junyang Shao <shaojunyang@google.com>
Lower to ZMUL for integers and ZFMUL for floats. The unpredicated integer ZMUL encoding is SVE2; its merging-predicated sibling and both float encodings are baseline SVE, so SVE2 buys only a better encoding, never availability. The loader records that split (cpuFeature is the operation's floor, unpredCpuFeature the carrier's level), the cpufeatures analysis now runs on arm64 and proves CPUsve2 from a dominating archsimd.ARM64.SVE2() check, and the generated rules use the unpredicated encoding only where that holds, falling back to the merging form under a synthesized all-true predicate: (MulInt8s x y) && v.Block.CPUfeatures.HasFeature(ssa.CPUsve2) => (ZMULB x y) (MulInt8s x y) => (ZMULMergingB x y <all-true>) A select over the fallback folds by replacing the all-true predicate, mirroring sveMergingPeephole's three forms. For #79781. Change-Id: I65c7b19b4686d6bb83ef7f9909ab2f42dcc910ec Reviewed-on: https://go-review.googlesource.com/c/go/+/822942 Reviewed-by: David Chase <drchase@google.com> Auto-Submit: Junyang Shao <shaojunyang@google.com> Reviewed-by: Junyang Shao <shaojunyang@google.com> TryBot-Bypass: David Chase <drchase@google.com>
Lower to ZSMULH and ZUMULH. As with the integer Mul, the unpredicated encodings are SVE2 and the predicated siblings baseline SVE, so the tests gate on ARM64.SVE2(). For #79781. Change-Id: I52dcc8ba25410813035f187a757e40af766141f9 Reviewed-on: https://go-review.googlesource.com/c/go/+/822943 LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Junyang Shao <shaojunyang@google.com> Auto-Submit: Junyang Shao <shaojunyang@google.com>
The SVE op tests spot-checked one or two element shapes each. Drive every op through every shape it is defined on, mirroring the Add/Sub pattern: generic emulations (addSaturated, subSaturated, mulHigh, negSlice, absSlice) join the existing slice helpers, and the per-shape driver wrappers are filled in for the missing widths. For #79781. Change-Id: I3ba5d48b6fe8ee1f3486593d913692485cf4c8f4 Reviewed-on: https://go-review.googlesource.com/c/go/+/827484 Auto-Submit: Junyang Shao <shaojunyang@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Junyang Shao <shaojunyang@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )