[pull] master from golang:master - #198
Merged
Merged
Conversation
Change-Id: I77bfba05f0c390ec8262e709193af7a9cec41f21 Reviewed-on: https://go-review.googlesource.com/c/go/+/827064 Auto-Submit: Mark Freeman <mark@golang.org> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Alan Donovan <adonovan@google.com>
CL 729201 removed itablinks. The runtime now walks the itab section of a module when it starts and when it loads a plugin. A plugin has its own copy of the itabs that the main program also has. Before CL 729201, dynamic symbol resolution pointed the itablinks entries of the plugin at the itabs of the main program, so add skipped them. Now add puts the copies of the plugin into the table as second entries for the same interface/type pairs. Type switches and type assertions compare the itab pointer of a value with the itab that the linker put into the module. In the plugin, that itab also resolves to the copy of the main program. After the itab table grows and rehashes its entries, find can return the copy of the plugin, and type switches in the main program take the default case. With Go 1.27, golangci-lint panics in go/ast.Walk with "unexpected node type *ast.DeferStmt" after it loads its third linter plugin (kubernetes/kubernetes#141663). Make add skip an itab when the table already has one for the same interface/type pair. Fixes #81303 Change-Id: Ia78e597fff9fd870924c1ebc94453523f3e7578b Reviewed-on: https://go-review.googlesource.com/c/go/+/826244 Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Jordan Liggitt <liggitt@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Ian Lance Taylor <iant@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
Lower to ZBIC (x &^ y), width-agnostic bitwise like ZAND and the first non-commutative one: the merging form is pinned resultInArg0 with no MOVPRFX-prefixed rule. For #79781. Change-Id: Ibcdd6b7449410205486fb4cd63f7584935c64b8d Reviewed-on: https://go-review.googlesource.com/c/go/+/822940 Auto-Submit: Junyang Shao <shaojunyang@google.com> Reviewed-by: Junyang Shao <shaojunyang@google.com> Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Capture AT_HWCAP2 in archauxv and expose HWCAP2_SVE2 as cpu.ARM64.HasSVE2 and archsimd.ARM64.SVE2(). The upcoming SVE Mul and MulHigh lower to SVE2-only unpredicated encodings, so their tests need the gate. For #79781. Change-Id: I8a8692e100e2ecdcbcaa66a1aa9b55bdf6e89a75 Reviewed-on: https://go-review.googlesource.com/c/go/+/822941 LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com> Auto-Submit: Junyang Shao <shaojunyang@google.com> Reviewed-by: Junyang Shao <shaojunyang@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )