[pull] master from golang:master - #197
Merged
Merged
Conversation
This importer uses "go build" rather than "go list -export":
- We have no importer going from the "i" format to a types2.Package.
- If we made one, types2 tests would use a different format in a build
context, which would be surprising.
This CL implements a simplified importer using the "u" (soon to be "p")
format. A dependency on testing.T is avoided to permit sharing across
tests and to minimize disruption to the existing test suites.
A second CL will swap out the existing types2 importer for this one.
Change-Id: If137876e5773f0b076868434ad1a5c56be26dc67
Reviewed-on: https://go-review.googlesource.com/c/go/+/825464
Reviewed-by: Alan Donovan <adonovan@google.com>
Auto-Submit: Mark Freeman <mark@golang.org>
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )