[pull] master from golang:master - #195
Merged
Merged
Conversation
…n peepholes Add IfElse and Masked to the scalable SVE vector types. IfElse lowers to ZSEL; Masked is a select against a zero vector. The SVE loader now groups an operation's predicated and unpredicated encodings into one definition: the unpredicated encoding (or, for a predicated-only operation, the merging one) carries the operation, and the sibling encodings' governing predicates become inVariants, implying predicated machine ops reached by peephole rather than by an API of their own. An encoding is classified as predicated from the spec's explanation text; see groupPredicationForms in sve/load.go. A select over an unpredicated operation folds into the operation's merging-predicated form: (ZSELB (ZADDB x y) z mask) => (ZADDMergingPrefixedB z x y mask) with cheaper MOVPRFX-free forms emitted first for a select whose "else" operand is already one of the sources; see sveMergingPeephole in gen_simdrules.go for why the general form requires commutativity. Add showcases only the commutative rules; the machinery also covers non-commutative and predicated-only operations, which arrive in later CLs along the chain. For #79781. Change-Id: I367da550aabee80119c3baa22b0c63381921df8d Reviewed-on: https://go-review.googlesource.com/c/go/+/818460 Reviewed-by: Junyang Shao <shaojunyang@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )