[pull] master from golang:master - #194
Merged
Merged
Conversation
The race detector on loong64 requires a 48-bit VMA. However, some
loong64 machines only have a 40-bit VMA (such as Loongson-2K3000),
which causes the race execution to fail with the following error:
FATAL: ThreadSanitizer: unsupported VMA range
FATAL: Found 39 - Supported 47
exit status 66
Skip these tests on loong64 for now.
Updates #78219
Change-Id: I8cc0b32e6e502431097c31e7935e933274126412
Reviewed-on: https://go-review.googlesource.com/c/go/+/825484
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
Reviewed-by: sophie zhao <zhaoxiaolin@loongson.cn>
Reviewed-by: Michael Matloob <matloob@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
This has 32 hits when building the std and cmd. This code looks very 1:1 with code already existing in prove's simplifyValue method. However known bits can catch cases prove misses because prove doesn't support the 0 & ? entry (where ? is the no-op argument being removed). This is important as it allows to optimize no-op ands when neither argument is const, but where one argument is completely shadowed. Prove's blind spot exists because prove will never have a known LSB after an unkown MSB. This means the 0 & ? case can never be proven by prove since it implies either both arguments are const (will be handled by generic.rules) or there must be a ? & ? case at the LSB. Change-Id: I837d707e7a4f6aae2c82d84e939bebe39dca6a09 Reviewed-on: https://go-review.googlesource.com/c/go/+/814340 Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Michael Pratt <mpratt@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This does not trigger when building the std nor cmd. This code looks very 1:1 with code already existing in prove's simplifyValue method. However known bits can catch cases prove misses because prove doesn't support the 1 | ? entry (where ? is the no-op argument being removed). This is important as it allows to optimize no-op ors when neither argument is const, but where one argument is completely shadowed. Prove's blind spot exists because prove will never have a known LSB after an unkown MSB. This means the 0 | ? case can never be proven by prove since it implies either both arguments are const (will be handled by generic.rules) or there must be a ? | ? case at the LSB. Change-Id: I33b3631774341beb62d5235c8bc82a6f2504d824 Reviewed-on: https://go-review.googlesource.com/c/go/+/814341 LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Michael Pratt <mpratt@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )