Shape List Zoom to, shaft-align mode rename, and third_party IDE filters - #249
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Occt_view::fit_shapes_in_view— frames a solid or group descendant solids while keeping camera orientation.Mode::Shape_cyl_align→Mode::Shape_shaft_align(hotkey idmode.cyl_align/Shp_cyl_alignunchanged).third_partyIDE filters inEzyCad_lib(CMakesource_group).gui.mdAlign shafts Options / Tab / Enter / dist-edit routing;usage.md+ CHANGELOG for Zoom to.Test plan
EzyCadbuild/EzyCad.sln:EzyCad_lib→third_party/{imgui,ImGuiColorTextEdit,tinyfiledialogs}docs/usage.mdShape List,src/doc/gui.mdOptions/keyboard, CHANGELOGCloses #248
Note
Low Risk
Localized UI/view framing and a mechanical mode enum rename with no hotkey or behavior changes; CMake changes affect IDE layout only.
Overview
Adds Shape List Zoom to on solid/group name and M context menus, calling new
Occt_view::fit_shapes_in_viewto frame one solid or all descendant solids with padding while keeping the current camera orientation (disabled for empty groups and solids without geometry).Renames
Mode::Shape_cyl_align→Mode::Shape_shaft_alignacross GUI/OCCT mode dispatch (toolbar, Tab/Enter routing, Optionsoptions_shape_shaft_align_mode_);mode.cyl_align/Shp_cyl_alignstay unchanged.CMake nests imgui, TextEditor, and tinyfiledialogs under a
third_partySolution Explorer tree forEzyCad_libviasource_group(TREE …)and header-onlytarget_sources.User and developer docs (CHANGELOG,
usage.md,gui.md,shape.md) and agent drafts are updated; remaining diff is mostly formatting.Reviewed by Cursor Bugbot for commit cca72b7. Bugbot is set up for automated code reviews on this repo. Configure here.